rivosinc / prometheus-slurm-exporter

Export select slurm metrics to prometheus
Apache License 2.0
26 stars 5 forks source link

[squeue] fix NONE time cli-fallback bug #27

Closed abhinavDhulipala closed 8 months ago

abhinavDhulipala commented 8 months ago

slurm 22.x can emmit NONE null vals on cmd line. Although we don't guarantee backward compatibility, this doesn't cost us anything to support. Bugs is red-green tested off-course. We might experience this same problem for NAbleFloats, but I'll wait for someone to file a bug against that before implementing it.

resolves #26

abhinavDhulipala commented 8 months ago

@jmcastelo I'll merge this once you confirm that this branch solves your problem. It took no effort to support. If you have a different idea in mind, feel free to open a separate PR