search

rivy / xbmc-script.audio.pandora

Pandora Radio for XBMC
GNU General Public License v3.0
15 stars 11 forks source link

API change in upcoming kodi v17 #23

Open fritsch opened 8 years ago

fritsch commented 8 years ago

Please replace: xbmc.Player( xbmc.PLAYER_CORE_MPLAYER ).play( url, item ) with: xbmc.Player().play( url, item )

Best regards fritsch

hackel commented 7 years ago

Unfortunately this change actually hard-crashes Kodi (17.0-rc2):

17:50:22.337 T:18446744072848152864  NOTICE: Trying to open: 44100 samplerate 12 channelMask 4 encoding
17:50:27.805 T:18446744072853190944  NOTICE: Pandora: Initializing v2.3.2
17:50:27.805 T:18446744072853190944  NOTICE: Pandora: sys.platform = linux2
17:50:33.838 T:18446744072853190944 WARNING: CSkinInfo: failed to load skin settings
17:50:34.026 T:18446744072853190944  NOTICE: Pandora: Window Initalized
17:50:34.729 T:18446744072853190944  NOTICE: Pandora: START: station_id = x
17:50:34.745 T:18446744072853190944  NOTICE: Pandora: getting more songs
17:50:35.727 T:18446744072853190944  NOTICE: Pandora: Adding song '...'
17:50:35.993 T:18446744072853190944  NOTICE: Pandora: Adding song '...'
17:50:36.031 T:18446744072853190944  NOTICE: Pandora: Adding song '...'
17:50:36.495 T:18446744072853190944  NOTICE: Pandora: Adding song '...'
17:50:39.852 T:18446744072688253216   ERROR: CCurlFile::FillBuffer - Failed: Transferred a partial file(18)
17:50:39.853 T:18446744072688253216 WARNING: CCurlFile::FillBuffer - Reconnect, (re)try 1
17:50:41.008 T:18446744072688253216   ERROR: CCurlFile::FillBuffer - Failed: Transferred a partial file(18)
17:50:41.009 T:18446744072688253216 WARNING: CCurlFile::FillBuffer - Reconnect, (re)try 1
17:50:41.884 T:18446744072688253216   ERROR: CCurlFile::FillBuffer - Failed: HTTP returned error 403
fritsch commented 7 years ago

You need to adjust your add-on. That's why I told it 12 months ago.

hackel commented 7 years ago

@fritsch I'm not sure what you mean. The report above is what I experienced after removing the xbmc.PLAYER_CORE_MPLAYER parameter from resources/lib/pandaplayer.py as you suggested. I guess something else must be going on to cause Kodi to crash entirely. Curl should definitely not be capable of doing so.

fritsch commented 7 years ago

Exactly. I just told you back in time that the mplayer bits were gone. Now one year later it seems other stuff changed.

Note the above was never meant as a fix but as a heads up: we changed sth.

Am 11.01.2017 3:26 vorm. schrieb "Ryan Hayle" notifications@github.com:

@fritsch https://github.com/fritsch I'm not sure what you mean. The report above is what I experienced after removing the xbmc.PLAYER_CORE_MPLAYER parameter from resources/lib/pandaplayer.py as you suggested. I guess something else must be going on to cause Kodi to crash entirely. Curl should definitely not be capable of doing so.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rivy/xbmc-script.audio.pandora/issues/23#issuecomment-271760278, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCfHZB4taE56WkYpy3ZAyO9OEx7IQ5Wks5rRD3MgaJpZM4HESb6 .

Katzekonig commented 7 years ago

following.