rixed / ramen

A stream processing language and compiler for small-scale monitoring
Other
14 stars 4 forks source link

commit before of *other* groups must really get rid of the group #1419

Closed rixed closed 2 years ago

rixed commented 2 years ago

The reason why commit-before does not clear the group is because it's committing the last but one value (therefore we already have a new value for that group). This does not hold when the group is committed because of an incoming tuple assigned to another group.

This also solve the issue of ever increasing group size due to grouping by non-factors.

The issue remain when local_last_out is used though: the groups must be kept forever, so we should make sure we group by factors only in that case.

rixed commented 2 years ago

OKish for now.