search

rixo / svench

A lightweight workbench to develop your Svelte components in isolation
svench-docs.vercel.app
207 stars 6 forks source link

typo found #19

Closed pateketrueke closed 3 years ago

pateketrueke commented 3 years ago

I'm not sure by this line seems bit wrong?

https://github.com/rixo/svench/blob/master/lib/preprocessor.js#L74

rixo commented 3 years ago

Hmm... Nothing obvious to me. Why?

Yes, indeed. Need to check that.

Have you encountered an actual problem pertaining to that?

pateketrueke commented 3 years ago

Have you encountered an actual problem pertaining to that?

not really, I just was reading the code and found Litteral with the double t, is that expected? Just by curiousity.

rixo commented 3 years ago

Yeah, this is a mistake. Will fix. Thanks for taking the time to report.

Rereading the code, it should break something like this:

<svench:options title={"title"} />

Svench options needs to be statically analyzable because they're parsed at compile time, and the above is static enough so it should be accepted. But I think the error you've found would make it to be rejected. I will confirm by testing and fix it when I get some calm :sweat_smile:

rixo commented 3 years ago

Will be fixed soon: https://github.com/rixo/svench/commit/aa8e4bce09212795d0fd4e8f1444e81b3848a289

Have you found any other interesting things while looking around?

rixo commented 3 years ago

This has been published on the v0.2.0-x beta branch.