search

rixo / svench

A lightweight workbench to develop your Svelte components in isolation
svench-docs.vercel.app
207 stars 6 forks source link

`npx svench` hangs when a style tag is inside of .svench file #40

Open jacob-8 opened 3 years ago

jacob-8 commented 3 years ago

To reproduce, clone https://github.com/jwrunner/svelte-ui/tree/b5f948ed234b4ae50f7e96bf2981d9484568d35e and run npx svench --verbose. You'll see [svench] Written: .svench\index.html logged out but it will never get to [routix] Written: .svench\src\routes.js as it should. It hangs forever (same with svench build).

I had to do make the style inline as seen in https://github.com/jwrunner/svelte-ui/commit/625a5183309924df92e4f71107995996e444370c to get npx svench to work.

Note also that anytime I had an incorrect import in a .svench file, I won't get an error message from npx svench but it will just hang in that same location. So that is another issue: throw useful errors messages when running into component syntax issues.

P.S. Svench is amazing and I love using it. Having these error messages and tips given would make it that much better.

rixo commented 2 years ago

Hey! Just wanna let you know that I was able to reproduce your problem with the provided example, but I haven't been able to pinpoint it yet. I don't think it's a problem with having a <style> tag in general, because it works in other cases, so there must be something specific in your situation... I'll be looking into it again.

Totally agree with you that errors should crash visibly, and having useful warnings would be ideal. I'll keep the warnings in mind, but will make sure I'll fix missing error reporting any time I can see it.