search

rixo / svench

A lightweight workbench to develop your Svelte components in isolation
svench-docs.vercel.app
207 stars 6 forks source link

Add directions about disableDependencyReinclusion #45

Closed dimfeld closed 2 years ago

dimfeld commented 2 years ago

When running SvelteKit with svench also installed in the project, vite-plugin-svelte tries to include svench's transitive dependencies in its prebundling step, which fails because this ends up including Node-only packages like cheap-watch. (See #43)

Adding disableDependencyReinclusion: ['svench'] to svelte.config.js fixes this, so I'm submitting a change to document this. What do you think?

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/rixodev/svench-docs/cBAycJ8myww8DC6xUGjTQMk549E4
✅ Preview: https://svench-docs-git-fork-dimfeld-vite-plugin-svelte-c75dec-rixodev.vercel.app

rixo commented 2 years ago

My idea was to automatize this setting as much as possible because it seems overly technical (or maybe even separate the Node / runtime parts of Svench into different packages)... But yeah, while this is not done, it is surely best to have instructions for coping with it.

Thanks!