search

rixwew / pytorch-fm

Factorization Machine models in PyTorch
MIT License
1.04k stars 225 forks source link

PaddingIdx #23

Closed MogicianXD closed 4 years ago

MogicianXD commented 4 years ago

Is it necessary to set the arg padding_idx of torch.nn.embbedding, as all features start from 1. I think it's better to avoid influence of 0.

rixwew commented 4 years ago

Thank you for the suggestion! Features starting from zero may not be in use now, but I sometime use them for private projects. I'd like to keep it that way because It doesn't affect the accuracy of the models.