taglib 삭제 여부, loginResult페이지 삭제

kimhanui commented 4 years ago

fmt와 fn 꼭 있어야 하는 것?? (기존 head.jsp의 jstl임)

@riyenas0925

새로 분리할 head.jsp에도 jstl 꼭 포함 시켜야함??

<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
<c:set var="path" value="${pageContext.request.contextPath}"/>

jstl 포함시켜야 함? ( 없어도 뷰 로딩은 잘 됨 ) -> 어떻게 분리시킬지 좀 달라짐.

loginResult페이지 삭제하겠음

안쓰는 페이지이고 어차피 로그인하면 home.jsp로 감

riyenas0925 commented 4 years ago

@kimhanui 이걸 사용하는곳이 uplodaResult에서 사용하던가?? 그래서 필요할것 같음

kimhanui commented 4 years ago

@riyenas0925

issue

head.jsp도 온전한 jsp 역할을 하려면 taglib가 꼭 필요한가?

<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
<c:set var="path" value="${pageContext.request.contextPath}"/>

적어도 이런게 꼭 있어야 하나? + fmt, fn어디서 쓰는지 몰겟음 ㅎ; js 파일에서 보이긴 하던데

코드 : head.jsp

<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>Sejong Track</title>
<!-- Tell the browser to be responsive to screen width -->
<meta content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no" name="viewport">
<!-- Bootstrap 3.3.7 -->
<link rel="stylesheet" href="bower_components/bootstrap/dist/css/bootstrap.min.css">
<!-- Font Awesome -->
<link rel="stylesheet" href="bower_components/font-awesome/css/font-awesome.min.css">
<!-- Ionicons -->
<link rel="stylesheet" href="bower_components/Ionicons/css/ionicons.min.css">
<!-- Theme style -->
<link rel="stylesheet" href="dist/css/AdminLTE.min.css">
<!-- iCheck -->
<link rel="stylesheet" href="plugins/iCheck/square/blue.css">
<!-- HTML5 Shim and Respond.js IE8 support of HTML5 elements and media queries -->
<!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
<!--[if lt IE 9]>
<script src="https://oss.maxcdn.com/html5shiv/3.7.3/html5shiv.min.js"></script>
<script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script>
<![endif]-->
<!-- Google Font -->
<link rel="stylesheet"
      href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600,700,300italic,400italic,600italic">

코드 : head-color.jsp

<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
<%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %>
<%@ taglib prefix="fn" uri="http://java.sun.com/jsp/jstl/functions" %>
<c:set var="path" value="${pageContext.request.contextPath}"/>

<head>

<%@ include file="head.jsp" %>              <!--      이 부분을 head.jsp로 만듦       -->

    <!-- AdminLTE Skins. Choose a skin from the css/skins
         folder instead of downloading all of them to reduce the load. -->
    <link rel="stylesheet" href="dist/css/skins/_all-skins.min.css">

    <!-- Morris chart -->
    <link rel="stylesheet" href="bower_components/morris.js/morris.css">
    <!-- jvectormap -->
    <link rel="stylesheet" href="bower_components/jvectormap/jquery-jvectormap.css">
    <!-- Date Picker -->
    <link rel="stylesheet" href="bower_components/bootstrap-datepicker/dist/css/bootstrap-datepicker.min.css">
    <!-- Daterange picker -->
    <link rel="stylesheet" href="bower_components/bootstrap-daterangepicker/daterangepicker.css">
    <!-- bootstrap wysihtml5 - text editor -->
    <link rel="stylesheet" href="plugins/bootstrap-wysihtml5/bootstrap3-wysihtml5.min.css">
    <!-- toastr -->
    <link rel="stylesheet" href="plugins/toastr/toastr.css"/>

    <link rel="stylesheet" href="plugins/pace/pace.min.css">

    <style>
        th {
            background-color: #f9f9f9;
        }

        .tbl_hover:hover {
            background-color: #f8d2d8;
            font-weight: bold;
        }

        .btn-hover {
            width: 125px;
            font-size: 16px;
            font-weight: 600;
            color: #fff;
            cursor: pointer;
            height: 55px;
            text-align: center;
            border: none;
            background-size: 300% 100%;

            border-radius: 50px;
            moz-transition: all .4s ease-in-out;
            -o-transition: all .4s ease-in-out;
            -webkit-transition: all .4s ease-in-out;
            transition: all .4s ease-in-out;
        }

        .btn-hover:hover {
            background-position: 100% 0;
            moz-transition: all .4s ease-in-out;
            -o-transition: all .4s ease-in-out;
            -webkit-transition: all .4s ease-in-out;
            transition: all .4s ease-in-out;
        }

        .btn-hover:focus {
            outline: none;
        }

        .btn-hover.color-1 {
            background-image: linear-gradient(to right, #25aae1, #40e495, #30dd8a, #2bb673);
            box-shadow: 0 4px 15px 0 rgba(49, 196, 190, 0.75);
        }

        .btn-hover.color-3 {
            background-image: linear-gradient(to right, #667eea, #764ba2, #6B8DD6, #8E37D7);
            box-shadow: 0 4px 15px 0 rgba(116, 79, 168, 0.75);
        }

        .btn-hover.color-4 {
            background-image: linear-gradient(to right, #fc6076, #ff9a44, #ef9d43, #e75516);
            box-shadow: 0 4px 15px 0 rgba(252, 104, 110, 0.75);
        }

        .btn-hover.color-9 {
            background-image: linear-gradient(to right, #25aae1, #4481eb, #04befe, #3f86ed);
            box-shadow: 0 4px 15px 0 rgba(65, 132, 234, 0.75);
        }

        #home-btn1 {
            margin-bottom: 20px;
        }

        #home-btn2 {
            margin-bottom: 20px;
        }

        .btn-nav1 {
            width: 80px;
            height: 80px;
            border-radius: 40px;
            background-color: #f56954;
            box-shadow: 0 4px 15px 0 rgba(45, 54, 65, 0.75);
            font-size: 16px;
            font-weight: 600;
            color: #fff;
            cursor: pointer;
            border: none;
        }

        .btn-nav2 {
            width: 80px;
            height: 80px;
            border-radius: 40px;
            background-color: #f39c12;
            box-shadow: 0 4px 15px 0 rgba(45, 54, 65, 0.75);
            font-size: 16px;
            font-weight: 600;
            color: #fff;
            cursor: pointer;
            border: none;
        }

        .nav-rb1 {
            z-index: 1;
            position: fixed;
            bottom: 120px;
            right: 20px;
        }

        .nav-rb2 {
            z-index: 1;
            position: fixed;
            bottom: 20px;
            right: 20px;
        }
    </style>

    <script>
        function go(text) {
            location.href = text;
            target: _self;
        }
    </script>
</head>
<body class="hold-transition skin-black sidebar-mini">
<div class="wrapper">

jsp 동적, 정적 include 참고링크 : https://cobbybb.tistory.com/2

riyenas0925 commented 4 years ago

@kimhanui 이렇게 하는게 head-color.jsp 의미에 더 맞지 않을까??

코드 : head.jsp

<%@ page contentType="text/html;charset=UTF-8" language="java" %>
<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
<%@ taglib prefix="fmt" uri="http://java.sun.com/jsp/jstl/fmt" %>
<%@ taglib prefix="fn" uri="http://java.sun.com/jsp/jstl/functions" %>
<c:set var="path" value="${pageContext.request.contextPath}"/>

<head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <title>Sejong Track</title>
    <!-- Tell the browser to be responsive to screen width -->
    <meta content="width=device-width, initial-scale=1, maximum-scale=1, user-scalable=no" name="viewport">
    <!-- Bootstrap 3.3.7 -->
    <link rel="stylesheet" href="bower_components/bootstrap/dist/css/bootstrap.min.css">
    <!-- Font Awesome -->
    <link rel="stylesheet" href="bower_components/font-awesome/css/font-awesome.min.css">
    <!-- Ionicons -->
    <link rel="stylesheet" href="bower_components/Ionicons/css/ionicons.min.css">
    <!-- Theme style -->
    <link rel="stylesheet" href="dist/css/AdminLTE.min.css">
    <!-- AdminLTE Skins. Choose a skin from the css/skins
         folder instead of downloading all of them to reduce the load. -->
    <link rel="stylesheet" href="dist/css/skins/_all-skins.min.css">
    <!-- Morris chart -->
    <link rel="stylesheet" href="bower_components/morris.js/morris.css">
    <!-- jvectormap -->
    <link rel="stylesheet" href="bower_components/jvectormap/jquery-jvectormap.css">
    <!-- Date Picker -->
    <link rel="stylesheet" href="bower_components/bootstrap-datepicker/dist/css/bootstrap-datepicker.min.css">
    <!-- Daterange picker -->
    <link rel="stylesheet" href="bower_components/bootstrap-daterangepicker/daterangepicker.css">
    <!-- bootstrap wysihtml5 - text editor -->
    <link rel="stylesheet" href="plugins/bootstrap-wysihtml5/bootstrap3-wysihtml5.min.css">
    <!-- toastr -->
    <link rel="stylesheet" href="plugins/toastr/toastr.css" />
    <!-- HTML5 Shim and Respond.js IE8 support of HTML5 elements and media queries -->
    <!-- WARNING: Respond.js doesn't work if you view the page via file:// -->
    <!--[if lt IE 9]>
    <script src="https://oss.maxcdn.com/html5shiv/3.7.3/html5shiv.min.js"></script>
    <script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script>
    <![endif]-->

    <!-- Google Font -->
    <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Source+Sans+Pro:300,400,600,700,300italic,400italic,600italic">

    <link rel="stylesheet" href="plugins/pace/pace.min.css">

    <style>
        th {
            background-color:#f9f9f9;
        }
        .tbl_hover:hover{
            background-color:#f8d2d8;
            font-weight:bold;
        }
        .btn-hover {
            width: 125px;
            font-size: 16px;
            font-weight: 600;
            color: #fff;
            cursor: pointer;
            height: 55px;
            text-align:center;
            border: none;
            background-size: 300% 100%;
            border-radius: 50px;
            moz-transition: all .4s ease-in-out;
            -o-transition: all .4s ease-in-out;
            -webkit-transition: all .4s ease-in-out;
            transition: all .4s ease-in-out;
        }
        .btn-hover:hover {
            background-position: 100% 0;
            moz-transition: all .4s ease-in-out;
            -o-transition: all .4s ease-in-out;
            -webkit-transition: all .4s ease-in-out;
            transition: all .4s ease-in-out;
        }
        .btn-hover:focus {
            outline: none;
        }
        .btn-hover.color-1 {
            background-image: linear-gradient(to right, #25aae1, #40e495, #30dd8a, #2bb673);
            box-shadow: 0 4px 15px 0 rgba(49, 196, 190, 0.75);
        }
        .btn-hover.color-3 {
            background-image: linear-gradient(to right, #667eea, #764ba2, #6B8DD6, #8E37D7);
            box-shadow: 0 4px 15px 0 rgba(116, 79, 168, 0.75);
        }
        .btn-hover.color-4 {
            background-image: linear-gradient(to right, #fc6076, #ff9a44, #ef9d43, #e75516);
            box-shadow: 0 4px 15px 0 rgba(252, 104, 110, 0.75);
        }
        .btn-hover.color-9 {
            background-image: linear-gradient(to right, #25aae1, #4481eb, #04befe, #3f86ed);
            box-shadow: 0 4px 15px 0 rgba(65, 132, 234, 0.75);
        }
        #home-btn1 {
            margin-bottom:20px;
        }
        #home-btn2 {
            margin-bottom:20px;
        }
        .btn-nav1 {
            width:80px;
            height:80px;
            border-radius:40px;
            background-color: #f56954;
            box-shadow: 0 4px 15px 0 rgba(45, 54, 65, 0.75);
            font-size: 16px;
            font-weight: 600;
            color: #fff;
            cursor: pointer;
            border:none;
        }
        .btn-nav2 {
            width:80px;
            height:80px;
            border-radius:40px;
            background-color: #f39c12;
            box-shadow: 0 4px 15px 0 rgba(45, 54, 65, 0.75);
            font-size: 16px;
            font-weight: 600;
            color: #fff;
            cursor: pointer;
            border:none;
        }
        .nav-rb1 {
            z-index:1;
            position: fixed;
            bottom:120px;
            right:20px;
        }
        .nav-rb2 {
            z-index:1;
            position: fixed;
            bottom:20px;
            right:20px;
        }
    </style>

    <script>
        function go(text){
            location.href = text;
            target: _self;
        }
    </script>
</head>

head-color.jsp

<%@ include file="head.jsp" %>

<body class="hold-transition skin-black sidebar-mini">
<div class="wrapper">

kimhanui commented 4 years ago

아 그래서 head-color라고 했구나 ㅇㅇ
login, join페이지에는 head가 불필요하게 무거워질것같긴한데
head 쪽이 다른 페이지는 login,join밖에 없으니까 굳이 또 내부적으로 안 나누고 저렇게 가도 괜찮은것 같음
반영해서 pr올릴게

riyenas0925 commented 4 years ago

@kimhanui ㅇㅋㅇㅋ 그럼 pr 올려줘

riyenas0925 commented 4 years ago

@kimhanui 내가 pr 올린거 확인 해보고 어프로브 한다음에 머지 해서 develop로 합치고 거기서 브랜치 따서 작업하고 pr 올리면 될것 같음

riyenas0925 / Sejong_Track_Management