rizafahmi / elixirjobs

Job portal for Alchemist
http://jobs.elixirdose.com/
130 stars 42 forks source link

No delete functionality for job posting? #35

Open fairbairn opened 8 years ago

fairbairn commented 8 years ago

So editing an existing job posting doesn't work. It thinks it's a New Job every time and doesn't carry over a good bit of the content, including the Job Description.

We also cannot find any way to remove a job posting.

Where is it?

rizafahmi commented 8 years ago

Hi @fairbairn , @manusajith already working on this issue. Hi @manusajith it seems delete button is not working right now. Edit description is working. Thanks!

optikfluffel commented 8 years ago

@rizafahmi I just tried to delete a job I created and it seems to work fine in Firefox and Chrome, but not in Safari.

fairbairn commented 8 years ago

We never saw a delete button at all. Has one been added?

We were in Firefox Linux. On Jun 18, 2016 6:29 AM, "Udo Kramer" notifications@github.com wrote:

@rizafahmi https://github.com/rizafahmi I just tried to delete a job I created and it seems to work fine in Firefox and Chrome, but not in Safari.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rizafahmi/elixirjobs/issues/35#issuecomment-226934505, or mute the thread https://github.com/notifications/unsubscribe/AFC2mRupWrsSQdDOJ2sDS_-Io1uZb7CEks5qM8iVgaJpZM4IreA7 .

optikfluffel commented 8 years ago

Yes, in https://github.com/rizafahmi/elixirjobs/commit/b85cf136b508385a6056044f9f782ed9605a1de6 by @manusajith.

manusajith commented 8 years ago

@rizafahmi @optikfluffel I drilled down the issue to dimmer.js component. It uses opacity as a parameter in one of the functions, which won't work in strict mode, and was causing js errors and not triggering the DELETE request.

I have edited the parameter of the function directly for now, but I believe a better solution would be a fix in the upstream itself(if not already reported and fixed).

But for the time being it should work :)