search

rizemon / pe

0 stars 0 forks source link

Specifying the currency parameter multiple times results in invalid currency error #15

Open rizemon opened 3 years ago

rizemon commented 3 years ago

image.png

Despite specifying a valid supported currency: SGD, as mentioned here:

image.png

specifying it twice causes it to not recognise the valid currency I specified.

nus-se-script commented 3 years ago

Team's Response

The format "set_curr c/CURRENCY" is given clearly in the UG. Only one c/CURRENCY parameter is accepted. Furthermore, when the mistake is made, a warning is given immediately, asking you to input a valid currency. This should be clear enough for the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: image.png

Because of this point in your notes under "Features", your command should be able to handle multiple parameters. Therefore, my command should work with the intended effect of setting the currency to SGD. Also, while you have an error asking the user to input a valid currency, to me, I did indeed put a valid currency but the warning given confuses me because I could not figure why my valid currency was being rejected.

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]