Special colors for function/symbol name in call/jmp instructions

rizinorg / cutter

Free and Open Source Reverse Engineering Platform powered by rizin

https://cutter.re

GNU General Public License v3.0

15.79k stars 1.15k forks source link

Special colors for function/symbol name in call/jmp instructions #1478

Open pelijah opened 5 years ago

pelijah commented 5 years ago

Is your feature request related to a problem? Please describe.

To make it easier to locate function/symbol names

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Usual function in IDA (one color)

Import thunk function in IDA

Imported symbol in IDA

Usual function in Binja

Import thunk function in Binja

Imported symbol in Binja

xarkes commented 5 years ago

Yep agreed!

ITAYC0HEN commented 5 years ago

isn't it an issue for r2? because we simply take r2's output

pelijah commented 5 years ago

isn't it an issue for r2? because we simply take r2's output

That's why I added the radare2 label.

ITAYC0HEN commented 5 years ago

I think it'd be better to open this issue in r2 side, otherwise it's less likely to get attention from r2 devs

On Mon, Apr 22, 2019, 23:22 Paul I. notifications@github.com wrote:

isn't it an issue for r2? because we simply take r2's output

That's why I added the radare2 label.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/radareorg/cutter/issues/1478#issuecomment-485539313, or mute the thread https://github.com/notifications/unsubscribe-auth/AEZ7M4W6PKG4UXDQ5P25ZXLPRYNANANCNFSM4HHKPZ7A .

xarkes commented 5 years ago

We can have both :)

radare commented 5 years ago

right now 'ec num red' is whats used because colorization happens before the replacing afaik, so changing the address will result in the same color for the flag/func.

i will add another color . assign me this thing

radare commented 5 years ago

fixed in r2 side

radare commented 5 years ago

honors ec flag

ITAYC0HEN commented 5 years ago

As for @trufae, this is now merged in r2. @pelijah, Can you check if we can make it work in Cutter now?

pelijah commented 5 years ago

Meh

>radare2 -v
radare2 3.5.0-git 22049 @ windows-x86-64 git.3.4.1-327-g26b4bc3da
commit: 26b4bc3daba5edcfde2d25a52a4eee55485e70de build: 05.05.2019__18:19:13,97

ITAYC0HEN commented 5 years ago

Should the theme you use ads this line in order to support the new color eval?

@trufae how can we make your PR work here? We nned instructions haha

xarkes commented 5 years ago

Any update on this?

pelijah commented 5 years ago