rizinorg / cutter

Free and Open Source Reverse Engineering Platform powered by rizin
https://cutter.re
GNU General Public License v3.0
15.72k stars 1.15k forks source link

Add option to rename local variable on ghidra decompiler view for all variables #2655

Open katzimoto opened 3 years ago

katzimoto commented 3 years ago

Is your feature request related to a problem? Please describe.

When i tried to use ghidra decompiler thorough cutter i found out that some of the variables can not be renamed, after an explanation on the telegram channel its seems to be because cutter didn't recognize this variables but ghidra do.

Describe the solution you'd like

I would like to be able to rename all variables from ghidra view i guess its would demand a deeper integration with ghidra.

Additional context

For now this is the the error that i received when tried to change variable name. image

Davincible commented 3 years ago

Pleaseeee

sylv-io commented 3 years ago

Nearly created an issue myself. IMHO This is crucial for RE :/

sylv-io commented 3 years ago

This is probably a rz-ghidra related issues. variablePresentInRizin() iterates over all variable names provided by getVariables(), which uses theafvj command. Therefore rizin has to recognize the local variable, before we can adapt it in cutter. (as pointed out by the message box)