search

rizinorg / cutter

Free and Open Source Reverse Engineering Platform powered by rizin
https://cutter.re
GNU General Public License v3.0
15.88k stars 1.15k forks source link

Remove the use of `rz_cons_html_filter()` from Cutter #2813

Open XVilka opened 3 years ago

XVilka commented 3 years ago

There is rz_cons_html_filter() call in src/core/Cutter.cpp that has output depending on the internal state of the RzCons. It should be substituted with reading the JSON output from rz_core_print_disasm_json() instead.

abhimnc commented 3 years ago

@XVilka Can I work on this issue? Can you give me a head start?

namangirdhar16 commented 3 years ago

hi @XVilka i would like to work on this issue, please assign this to me.

XVilka commented 3 years ago

We can't assign external contributors. Just go ahead and send a PR when you are ready.

Nivig1310 commented 2 years ago

Hello @XVilka , is it as simple as changing the functions? Can you give me some more details?

karliss commented 2 years ago

No at the moment it isn't as simple as changing functions. There might have a been a bunch of easy cases before #2666 now only hard cases remain. At least to deal with it in meaningful way which doesn't replace rz_cons_html_filter with something equally bad. I don't think this should be marked as good first issue anymore.