Bad cutter theme colors

[ret2libc]

Environment information

• Operating System: Fedora 36
• Cutter version:
• Obtained from:
  • [ ] Built from source
  • [x] Downloaded release from Cutter website or GitHub: ./Cutter-git-2022-06-12-84b33d50bdd666825eada79a5fe0a2039bc2b1c6-x64.Linux.AppImage
  • [ ] Distribution repository
• File format: any

Describe the bug

There is a black background which is quite bad to see and also hides some text at times. This appears both in the graph mode and in the disassembly mode, but in particular in the disassembly mode it is very bad.

To Reproduce

Just open a binary and go to Graph or Disassembly.

Expected behavior

A much cleaner color theme, at least by default.

Screenshots

(note I had to select the lines to make the call comments visible)

Additional context

[thestr4ng3r]

The main issue here seems to be the black background. Since your native theme is light-ish and it detects that, which can be seen by the fact that it uses "cutter", not "ayu". But the background should match that too.

[ITAYC0HEN]

This should not happen so indeed a bug 👍 default themes should look good from the start, and here something went wrong with the background.

Personally can't reproduce

[ret2libc]

On Mac I can't reproduce anymore after cleaning a bit older files

[XVilka]

@ret2libc how it looks like now?

[ret2libc]

This is on MacOS. I want to check again a clean ubuntu VM.

[ret2libc]

Closing, after cleaning also the other PC it works well, sorry for the noise

[ret2libc]

Need to reopen. It appears as soon as I reinstall rizin and then build/install cutter (with bundled_rizin=off)

[ret2libc]

It seems to happen only when stuff are installed in ~/.local. I installed rizin in /usr/local and cutter too and it works there. I guess there is something wrong when files are loaded from ~/.local.

Somehow when installed in ~/.local I saw the cutter theme file being overwritten by something else and in particular all options in cutterOptionColors were commented out in the cutter theme file.

[karliss]

Something isn't quite right with color themes, but my observations where slightly different. I used a cutter dev build with bundled rizin and no installation. My native theme is light and cutter recognizes that it's light as indicated by list of available themes. I observe following:

• cga theme -> gray text for mov very hard to read
• dark (?? doesn't look that dark to me) -> call has dark blue text on black background
• default -> looks mostly readable but it's a dark theme, why is it available in light mode
• durian -> one more theme with dark background in the light list
• gb -> some of the light green text is unreadable, was this theme meant for dark background?
• tango -> light gray text on white background for many instructions, not the worst but also not very easy to read

Dark list seems mostly fine.

• white2 -> opposite of dark, has dark dark background I am slightly confused by the name, mov is black on dark background

Would be good to check:

• compare to how those themes look in rizin
• compare to how those themes look in older version of Cutter
• does the background come from color theme, overall qt theme or somewhere else

[karliss]

As a side note maybe the appearance settings should have a checkbox "show all color themes" for situations where the automatic dark/light classification gets confused or if you want to keep your light desktop/qt theme but still have dark colors the disasembly.

Also maybe the "Color theme" selection should be renamed to "disassembly color theme" to better reflect what it controls. Although there was idea to paletize existing qt themes for easier maintaince and potentially easier user customizations. In which case the color pallet controls for QT theme could potentially be merged with disassembly color theme, but in that case the settings label can be changed again.

[karliss]

name	Cutter dev	Cutter 2.0	rizin 0.4	note
cga	bad gray text, white background	not available	has dark(default?) background	clasify as dark theme and force dark background if needed
dark	confusing, slightly bad	same as dev	dark(default?) background	clasify as dark or dark+light theme
default	looks dark	not available	same as cutter dev	maybe should be classified as dark theme
durian	looks dark		looks fine on white background	why is dark background forced in Cutter, when in rizin it uses default terminal background
gb	slightly bad	not available	dark(default?) background	clasify as dark theme, force dark background if needed
tango	slightly bad	same as dev	looks better in dark, but with yellow or light nonwhite background also reasonable	clasify as dark+light theme, maybe override background in light mode
--	--	--	--
dark? themes
--	--	--	--
white2	confusing name, slightly bad	not available	bad on dark background, good on light	classify as light theme