search

rizinorg / cutter

Free and Open Source Reverse Engineering Platform powered by rizin
https://cutter.re
GNU General Public License v3.0
15.88k stars 1.15k forks source link

Need "go to address" in disassembler panel #3092

Open the-Arioch opened 1 year ago

the-Arioch commented 1 year ago

See https://github.com/rizinorg/cutter/issues/3090 for information.

See the 0x77c5d45a 0f 85 7a ec ff ff jne 0x77c5c0da opcode.

Okay, for whatever thinkable reason Vutter does not provide auto-magic scrolling. Sad, but bugs happen.

Then human should be provided menu item and hotkey to just copy-paste the address and have it immediately scrolled into disassm panel (and 2-3 lines above it too, for extra context).

Even Delphi debugger provides this, albeit being faaaar from the berst tools for asm-level things.

BTW, this funciton in Delphi debugger also allows simple expressions, like CPU registers + offsets, not only a literal constant. Not sure about variables addresses, variables values and named constants values, don't recall.

Since you already mark some variables in the disasm panel, referencing their names and/or values in such a "goto" command might be useful too. Since you provide some emulation - then perhaps at least during emulation the registers should also be treated as variables' values.

But at bare minumum i think human should be able to select any literal in the disasm panel, r-click, and have "Go to address" command. Invoked, it should present a prompt for the address (with selected text, if any, copied into it), so user could hit enter/OK to confirm and scroll to, or edit the pre-copied address and then hit Enter

the-Arioch commented 1 year ago

Just similarly to "add flag", but with edit/confirm dialog in between

menu

the-Arioch commented 1 year ago

I found it in the app-global toolbar, and it was not intuitive it would be there... Especially as there can be many disassembler panels or floating windows

Better than nothing, but... i think it is rather counterintuitive

2023-02-02 04_43_51-Cutter – WinTargets_xp_x64_user32 dll

the-Arioch commented 1 year ago

Still, "open the selected address in NEW window" is wanted too, and seemingly cannot be optained bvia search bar in the toolbar

karliss commented 1 year ago

Still, "open the selected address in NEW window" is wanted too

That's what the "show in" submenu does. You can open it either in new disassembly (hexdump, graph or decompiler) panel or one of the existing panels.

For quick navigation there also double click which should jump to it in current disassembly window.

karliss commented 1 year ago

Testing it with latest release build I had lying around, seems like in some cases with conditional jumps it doesn't work, while it works fine with unconditional jumps. This means that there are no problems with UI, but either in backend not recognizing the reference to address or it getting lost somewhere in the communication between Cutter and rizin.

the-Arioch commented 1 year ago

My gut feeling it is more about negative addresses (relative to function start) rather than specific opcode (conditional branching)

https://github.com/rizinorg/cutter/issues/3090#issuecomment-1413067548