rizinorg / cutter

Free and Open Source Reverse Engineering Platform powered by rizin
https://cutter.re
GNU General Public License v3.0
15.88k stars 1.15k forks source link

DisAsm: double-click and tripple-click should select text at cursor. #3097

Open the-Arioch opened 1 year ago

the-Arioch commented 1 year ago

See https://github.com/rizinorg/cutter/issues/3090 for information.

See the 0x77c5d45a 0f 85 7a ec ff ff jne 0x77c5c0da opcode.

I want to go to the target 0x77c5c0da address, but i can not do it a convenient way - see #3092

So, okay, i want to at list quickly copy it. But it is harder than it needs too.

Text editors and WWW browsers have a convenient feature: double-click selects the whole word, and triple-click selects the whole line por paragraph. Would be helpful here too.

Also, Opera/Presto browser had yet another convenience: after double or triple left-click text selection, the context menu for the selected text was opened immediately, skipping the need for an extra right-click. Sounds trivial, but really convenient it was.

Kaldesyvon commented 1 year ago

Hello, can I get assigned to this issue? I am new to contributing, I have already read the contributing pages.

xarkes commented 1 year ago

Here you go, feel free to simply say you start working on it and open a PR linking to this issue so people can see your progress

Kaldesyvon commented 1 year ago

Hi I was looking into it and I removed event filter on line 110
110 // mDisasTextEdit->viewport()->installEventFilter(this); in DisassemblyWidget.cpp and double click is now registered. The comment for that line explicitly says that double click is intercepted, so I suppose it have to be like that.

I am asking why it is intercepted and if just removing this event filter is enough or it is drastically changes other functionalities?

Thank you.

Kaldesyvon commented 1 year ago

Hello, I did some work, but I am getting this error while pushing:

cutter: ERROR: Permission to rizinorg/cutter.git denied to Kaldesyvon. Could not read from remote repository. Please make sure you have the correct access rights and the repository exists.

Is there any chance that issue is on your side? If not, then help me pls, I updated remote to use ssh, and I have ssh keys added. I am getting positive response from ssh -T git@github.com.

Thank you

XVilka commented 1 year ago

Hello, I did some work, but I am getting this error while pushing:

cutter: ERROR: Permission to rizinorg/cutter.git denied to Kaldesyvon. Could not read from remote repository. Please make sure you have the correct access rights and the repository exists.

Is there any chance that issue is on your side? If not, then help me pls, I updated remote to use ssh, and I have ssh keys added. I am getting positive response from ssh -T git@github.com.

Thank you

You need to fork the repository first, and push there instead.

Kaldesyvon commented 1 year ago

Thank you, I have created PR.

ret2libc commented 1 year ago

https://github.com/rizinorg/cutter/pull/3252#issuecomment-1782886043

https://github.com/rizinorg/cutter/pull/3252#issuecomment-1783103950