Added option to add new flags from hexdump #2932

[Rohan-Sagar]

Your checklist for this pull request

• [ X ] I've read the guidelines for contributing to this repository
• [ X ] I made sure to follow the project's coding style
• [ X ] I've updated the documentation with the relevant information (if needed)

Detailed description

• Problem:
  • Currently, users can add new flags from the disassembly widget using the right-click menu and a keyboard shortcut. However, this functionality is missing in the hexdump widget.
• Proposed solution:
  • To address this issue, we propose the following solution:
    • Add Action for Adding New Flag:
      • Introduce a new action in the right-click menu of the hexdump widget for adding a new flag. This action will provide users with a convenient option to add flags directly from the hexdump view.
    • Synchronize with Disassembly Widget:
      • Ensure that the keyboard shortcut for adding flags from the hexdump widget is synchronized with the shortcut used in the disassembly widget. This consistency will enhance the user experience and streamline flag management across different views.
    • Implementation Details:
      • Add a QAction object (actionFlag) within the HexWidget class to represent the action for adding a new flag.
      • Add a QAction object (actionDeleteFlag) within the HexWidget class to represent the action for deleting a flag.
      • Implement the onActionAddFlagTriggered() slot to handle user-triggered events for adding flags within the HexWidget class.
      • Implement the onActionDeleteFlagTriggered() slot to handle user-triggered events for deleting flags within the HexWidget class.
      • Update the context menu event handling (contextMenuEvent()) in the HexWidget class to include the new action for adding flags.
      • Introduce the parentForDialog() function in the HexWidget class to provide the parent widget for dialogs spawned within the hexdump view.

Test plan (required)

Functionality Test:

• Open the application and navigate to the hexdump view.
• Right-click in the hexdump widget to bring up the context menu.
• Select the option to add a new flag. Verify that a dialog box or input field appears with the correct address, allowing you to enter a flag name and size.
• Enter a valid flag name and size, then confirm the action.
• Verify that the new flag is correctly added to the list of flags and is visible in the hexdump widget or disassembly widget.

Keyboard Shortcut Synchronization Test:

• While in the hexdump view, use the keyboard shortcut (key bind N) for adding a new flag (ensure this is the same shortcut used in the disassembly widget).
• Confirm that the action for adding a new flag is triggered, similar to the right-click context menu action.
• Follow the same steps as in the functionality test to add a flag and verify its addition.

Cross-Widget Synchronization Test:

• After adding a new flag in the hexdump widget, switch to the disassembly view.
• Verify that the newly added flag is also reflected in the disassembly widget and any other relevant parts of the application where flags are displayed.

Closing issues

[karliss]

So is this ready for review or is it still WIP (work in progress)? Note if the PR is still work in progress, but you just wanted to give a heads up early, and there are things you want to change before review, you can use the Github draft feature.

[Rohan-Sagar]

So is this ready for review or is it still WIP (work in progress)? Note if the PR is still work in progress, but you just wanted to give a heads up early, and there are things you want to change before review, you can use the Github draft feature.

Thank you for the notice. I've marked the pull request as a draft to indicate that it's ready for review, but there may still be some changes. Once all adjustments are made, I'll mark it as ready for review again.

[karliss]

@Rohan-Sagar Are you planning to finish cleaning up this PR ?

[Rohan-Sagar]

@karliss I’m getting this issue in the continuous-integration check:

Dependency libzstd skipped: feature use_sys_libzstd disabled Downloading zstd source from https://github.com/facebook/zstd/releases/download/v1.5.5/zstd-1.5.5.tar.gz <urlopen error [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond> A fallback URL could be specified using source_fallback_url key in the wrap file ........\rizin\meson.build:621:2: ERROR: could not get https://github.com/facebook/zstd/releases/download/v1.5.5/zstd-1.5.5.tar.gz is the internet available?

Any idea what could be going wrong?