rizinorg / cutter

Free and Open Source Reverse Engineering Platform powered by rizin
https://cutter.re
GNU General Public License v3.0
15.32k stars 1.14k forks source link

Processes/ThreadsWidget: fix ODR violations by moving Column enums into classes #3317

Closed ajakk closed 3 months ago

ajakk commented 3 months ago

Your checklist for this pull request

Detailed description

The ThreadsWidget and ProcessesWidget column index enumerators having the same name with differing definitions violates the C++ One Definition Rule. These patches move those enums into the respective classes of each of these widgets, happily allowing differing definitions with the same name, and brings these two widgets into alignments with other widgets that define the column indexes similarly.

Test plan (required)

I've tested that the widgets touched here still function as expected.

Closing issues

Closes #3316

ajakk commented 3 months ago

Thanks!