Move Unsafe function feature in radare2

[Maijin]

Move Unsafe function feature in radare2 -

https://github.com/radare/radare2/blob/217edd4be5e4f31e728156d19f1b3ddcaa4c512a/libr/anal/d/types.sdb.txt#L184

[radare]

This is called flag tags. It was already there. See libr/flag/d

On 7 Sep 2018, at 13:37, Maijin notifications@github.com wrote:

Move Unsafe function feature in radare2 -

https://github.com/radare/radare2/blob/217edd4be5e4f31e728156d19f1b3ddcaa4c512a/libr/anal/d/types.sdb.txt#L184

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[Maijin]

@trufae This needs to be merged with the function definition database, it's a dup

[Maijin]

To create a consolidate database, something like XXX.unsafe similar to the noreturn in the types sdb

[ITAYC0HEN]

is this tracked in r2?

[Maijin]

Not yet

[ITAYC0HEN]

@radare @Maijin what would be the best option to create this in r2?

[xarkes]

I wonder if we should not remove this feature for now.

[ITAYC0HEN]

what are your arguments?

[Maijin]

@ITAYC0HEN there is a database for this on r2 side see @trufae messages previously. But this needs to be merge with the function prototype database with something like "XXX.unsafe=1".

[xarkes]

I think the list we have is non exhaustive, linux only (afair), and so not very useful. Either do it correctly which is having a complete list of "dangerous" functions, otherwise it might not be that interesting, or remove it. As said I prefer to have stable things than "work in progress" or "proof of concept" things inside Cutter.

[ITAYC0HEN]

@xarkes so you want to remove it? do you find it useless?

[xarkes]

I wouldn't say it's totally useless, but it's a feature that should be supported in radare2, or as a plugin.

[radare]

its already in r2, read my comments above

[radare]

I have created this issue to improve it https://github.com/radare/radare2/issues/13782 feedback is welcome