rizinorg / rizin

UNIX-like reverse engineering framework and command-line toolset.
https://rizin.re
GNU Lesser General Public License v3.0
2.66k stars 357 forks source link

Convert `i`/`rz-bin` calls inside Rizin to the API calls #1475

Open XVilka opened 3 years ago

XVilka commented 3 years ago
librz/main/rz-find.c
409:        rz_sys_cmdf("rizin"
421:            rz_sys_cmdf("rizin -qc \"/E %s\" \"%s\"", kw, efile);

librz/egg/egg_Cfile.c
289:    output = rz_sys_cmd_strf("rz-bin -o '%s.text' -O d/S/'%s' '%s'.o",

librz/core/cmd_debug.c
1673:                           res = rz_sys_cmd_strf("env RZ_BIN_PREFIX=\"%s\" rz-bin %s-B 0x%08" PFMT64x " -S \"%s\" | grep \"%s\"", name, mode, baddr, filesc, sect);
1676:                           res = rz_sys_cmd_strf("env RZ_BIN_PREFIX=\"%s\" rz-bin %s-B 0x%08" PFMT64x " -S \"%s\"", name, mode, baddr, filesc);

Originally posted by @XVilka in https://github.com/rizinorg/rizin/issues/1238#issuecomment-870335117

I have removed the following: ``` librz/core/cmd_info.c 703: rz_sys_cmdf("rz-bin -O \"%s\" \"%s\"", rz_str_trim_head_ro(input + 1), desc->name); 706: rz_sys_cmdf("rz-bin -O help"); ``` because those are not `i` commands.
ret2libc commented 2 years ago

I didn't see any work on this during this time, so I doubt it will be done for 0.4.0. I'm removing the 0.4.0 milestone for now until someone starts to actively looking at this.

cc @XVilka

XVilka commented 2 years ago

Only partially resolved.