search

rizinorg / rizin

UNIX-like reverse engineering framework and command-line toolset.
https://rizin.re
GNU Lesser General Public License v3.0
2.66k stars 356 forks source link

rewrite `rz_core_print_disasm_json` and `rz_core_print_disasm` #2554

Open wargio opened 2 years ago

wargio commented 2 years ago

the functions rz_core_print_disasm_json and rz_core_print_disasm needs to be refactored or better rewritten and deprecated since used only in the oldshell.

These functions depends also on some other code that prints disassembly which also needs to be rewritten.

imbillow commented 2 years ago

Hi! Do you have plans to write this?

wargio commented 2 years ago

not yet, if you want to take this, i'm ok with that.

imbillow commented 2 years ago

the rz_core_print_disasm and RzDisasmState, the related code is about 5000 lines, so complicated

https://github.com/rizinorg/rizin/blob/74e499a1813aa6e04b505b863b3251ba10ac2e0d/librz/core/disasm.c#L80-L5734

wargio commented 2 years ago

welcome to my every day nightmare :/

XVilka commented 2 years ago

@wargio @imbillow shall we close this one as completed?

imbillow commented 2 years ago

I'm not sure, but it doesn't seem to be fully finished (rz_core_print_disasm)

wargio commented 2 years ago

not yet