Closed XVilka closed 5 months ago
Hey @XVilka I would like to work on this issue! it will be my first time contributing
Sure, @hady68, go ahead.
Sure, @hady68, go ahead.
Can you please list down the steps that are needed to solve this one?
See the commit mentioned in the issue, just do similarly.
See the commit mentioned in the issue, just do similarly.
Sure okay, can you please assign this to me
See the commit mentioned in the issue, just do similarly.
Sure okay, can you please assign this to me
GitHub doesn't allow assigning people who aren't part of the organization. Just send a PR and link to this issue, that should be enough. Don't forget to check https://github.com/rizinorg/rizin/blob/dev/CONTRIBUTING.md and https://github.com/rizinorg/rizin/blob/dev/DEVELOPERS.md
See the commit mentioned in the issue, just do similarly.
Sure okay, can you please assign this to me
GitHub doesn't allow assigning people who aren't part of the organization. Just send a PR and link to this issue, that should be enough. Don't forget to check https://github.com/rizinorg/rizin/blob/dev/CONTRIBUTING.md and https://github.com/rizinorg/rizin/blob/dev/DEVELOPERS.md
Got it thanks will do so
@hady68 sorry, there is actually a better example - see how the state is saved into the context in librz/analysis/p/analysis_asm_cs.c
Hi @XVilka, I have worked on one of the files, and wanted to cross-check if this is what you're looking for, then I can go forward for other files as well, attaching the link to a PR in my forked repo, please have a look and let me know.
https://github.com/hady68/rizin/pull/1
@hady68 no, you need to introduce a context structure since the omode
of that code is cached between different disassemble()
function calls.
of that code is cached between different
disassemble()
function calls.
Added the above here -> https://github.com/hady68/rizin/pull/1/commits/af37dc33a3ecc9772274d805fea6d9ba796b17e5 please check
@hady68 yes, the crux of it is right. Please fix the indentation though (use sys/clang-format.py
)
@hady68 yes, the crux of it is right. Please fix the indentation though (use
sys/clang-format.py
)
Alright will fix it, working on the other files now
Removed static Variables from RzAsm #4100
@imbillow could you please remove the one static var left in RzAsm
tricore plugin?
See https://github.com/rizinorg/rizin/commit/2c9a7008e9e30a10ff42c0422b1ef7d6579b8dab as an example how to handle this.