search

rizinorg / rizin

UNIX-like reverse engineering framework and command-line toolset.
https://rizin.re
GNU Lesser General Public License v3.0
2.72k stars 363 forks source link

Do not install zstd pkg-config and header files with Rizin #4438

Open XVilka opened 7 months ago

XVilka commented 7 months ago

Suppose you build Rizin with all subprojects bundled, without using anything from the system. In that case, the ZSTD subproject also installs libzstd.pc and its headers, which might install/compile some other software since it tries to pick up a half-available library from the Rizin installation instead of the system-wide installation. Super-annoying. For example, QEMU always fails to compile because of that, until I remove those installed files. We should not install them, just like we do not install anything for any other bundled subproject.

ret2libc commented 7 months ago

I think this was reported recently in Fedora as well.