rizinorg / rizin

UNIX-like reverse engineering framework and command-line toolset.

https://rizin.re

GNU Lesser General Public License v3.0

2.51k stars 341 forks source link

Refactor of rz-test to use thread safe functions. #4506

Closed wargio closed 1 month ago

wargio commented 1 month ago

do not squash

Your checklist for this pull request

[ ] I've read the guidelines for contributing to this repository
[ ] I made sure to follow the project's coding style
[ ] I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
[ ] I've added tests that prove my fix is effective or that my feature works (if possible)
[ ] I've updated the rizin book with the relevant information (if needed)

Detailed description

This uses the thread-safe functions and cleans up a bit the rz-test code.

Now we automatically detect the core number and use them all unless -j <n> is specified.

wargio commented 1 month ago

The unit tests fails are unrelated to this PR. check dev

XVilka commented 1 month ago

The unit tests fails are unrelated to this PR. check dev

I know they are unrelated, I thought the error improved after this one, but it apparently happended in dev already. So yes, ignore that part of the comment.

XVilka commented 1 month ago

I think having overall count is useful though, could you please also add a column with all tests ran?

Also maybe a final report, how many OK, BR, XX are at the end total?

wargio commented 1 month ago

I think having overall count is useful though, could you please also add a column with all tests ran?

i have removed it by mistake. i changed the code and now it prints it.

wargio commented 1 month ago

The issue with Bindgen is unrelated to this PR

AssertionError: File /usr/include/librz/sdb/ls.h does not exist

XVilka commented 1 month ago

The issue with Bindgen is unrelated to this PR
AssertionError: File /usr/include/librz/sdb/ls.h does not exist

https://github.com/rizinorg/rz-bindgen/pull/64

wargio commented 1 month ago

A running total would be nice -- I generally use it to see how far the build has progressed through the tests. Not sure whether it's strictly necessary, or how to integrate that info in a clean manner.

The running total is printed at the end when -L is used.

[21179/21179]    20129 OK      1016 BR        0 XX       34 FX