search

rizinorg / rizin

UNIX-like reverse engineering framework and command-line toolset.
https://rizin.re
GNU Lesser General Public License v3.0
2.51k stars 341 forks source link

Visual mode percentage doesn't work #4518

Closed XVilka closed 3 weeks ago

XVilka commented 1 month ago

@PeiweiHu it doesn't work in the simple visual mode. Simply do rizin /bin/ls, then V and scroll. You can try different modes with p/P and scroll - it also always stays at 0%.

What's interesting, that it works in the "last" of the visual modes (the "hexII" mode, the "sparse hexdump", press V then p multiple times), while doesn't in any other mode.

Originally posted by @XVilka in https://github.com/rizinorg/rizin/issues/4494#issuecomment-2119470762

PeiweiHu commented 3 weeks ago

Will try to address it once I'm free.

PS: please also feel free to take it for anyone that is interested in it.

PeiweiHu commented 3 weeks ago

Hi, @XVilka

I tried but failed to reproduce the errors. It seems that the percentage works normally on my pc. I post the video in the following. Do I miss any steps to reproduce it?

https://github.com/rizinorg/rizin/assets/58985155/06a7beb7-4665-468d-bce5-a575c9da3e28

TheN00bBuilder commented 3 weeks ago

@PeiweiHu I was able to reproduce the original error by doing the same thing you did in your video. Typing the same things you did makes the percentage not update when scrolling. Not sure if it makes a difference but I'm on Ubuntu 20.04.

I can attempt to look at this later this week if you're still having issues reproducing the bug. Can't guarantee anything as I'm still really unfamiliar with the codebase, but maybe I can help pinpoint the issue.

PeiweiHu commented 3 weeks ago

@TheN00bBuilder Thank you so much! I can reproduce now without using tmux.