Revert #4506 - Githubissues

kazarmy commented 1 month ago

Your checklist for this pull request

[X] I've read the guidelines for contributing to this repository
[ ] I made sure to follow the project's coding style
[ ] I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
[ ] I've added tests that prove my fix is effective or that my feature works (if possible)
[ ] I've updated the rizin book with the relevant information (if needed)

Detailed description

@wargio did a fine job with #4506 but unfortunately it broke the macos CI build and therefore this pr proposes that #4506 (and the associated pr #4510) be reverted for now until its kinks are ironed out.

Test plan

All builds are green.

Closing issues

...

kazarmy commented 1 month ago

Updated the pr description.

wargio commented 1 month ago

The macos CI is not broken. never worked properly. it pops up the UI asking for admin password and locks there. i tested this on osx 12 on x64 machine.

wargio commented 1 month ago

https://github.com/rizinorg/rizin/pull/4516

wargio commented 1 month ago

What the hell. i reverted previously and still had the same issue, and on yours works instead.

wargio commented 1 month ago

Gimme this week and i will fix this.

kazarmy commented 1 month ago

i don't have an x86 mac, and i see that woodpecker runs its debug tests just fine (with an occasional error now and then) so ok and good luck!

rizinorg / rizin

Revert #4506 #4519