[v] I made sure to follow the project's coding style
[v] I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
[v] I've added tests that prove my fix is effective or that my feature works (if possible)
[?] I've updated the rizin book with the relevant information (if needed)
Detailed description
This adds MS-DOS and Win32 timestamp conversions in the rz-ax util / command. These have been added as flag -m and -W respectively. The relevant help / print statements have been edited. Given rz_time_stamp_is_dos_format is in the codebase, we can "guess" if the timestamp is MS-DOS or Unix, so it may be better to have that all under the -t command, but I don't know if that's a good plan. Would like feedback from the maintainers on everything.
I didn't see any appropriate place in the rizin book for this, but I did update the help command for rz-ax with the new field and confirmed it shows up.
Test plan
As long as the rz_time_date_dos_to_string function is tested, this can be considered tested. I did not see any tests explicitly testing the -t command in the test database.
Your checklist for this pull request
Detailed description
This adds MS-DOS and Win32 timestamp conversions in the
rz-ax
util / command. These have been added as flag-m
and-W
respectively. The relevant help / print statements have been edited. Givenrz_time_stamp_is_dos_format
is in the codebase, we can "guess" if the timestamp is MS-DOS or Unix, so it may be better to have that all under the-t
command, but I don't know if that's a good plan. Would like feedback from the maintainers on everything.I didn't see any appropriate place in the rizin book for this, but I did update the help command for
rz-ax
with the new field and confirmed it shows up.Test plan
As long as the
rz_time_date_dos_to_string
function is tested, this can be considered tested. I did not see any tests explicitly testing the-t
command in the test database.Closing issues
closes #4515