rizinorg / rizin

UNIX-like reverse engineering framework and command-line toolset.
https://rizin.re
GNU Lesser General Public License v3.0
2.72k stars 363 forks source link

Stderr is not passed to remote session #560

Open caribpa opened 3 years ago

caribpa commented 3 years ago

Work environment

Questions Answers
OS/arch/bits (mandatory) Arch Linux x64
File format of the file you reverse (mandatory) ELF
Architecture/bits of the file (mandatory) x86/64
rizin -v full output, not truncated (mandatory) rizin 0.2.0-git @ linux-x86-64 commit: 3e64a2e16a4a4d4bc7879299152e67c99084a685, build: 2021-02-09__17:04:35

Expected behavior

Opening a remote session with == <fd> shows the stderr messages in the client instead of the server.

Actual behavior

Opening a remote session with == <fd> shows the stderr messages only in the server.

Steps to reproduce the behavior

Server

Client

Using a TCP server (rz -q -c '=t 8080' rizin) don't show the stderr in any of the parts of the connection.

Using -2 in the server only silences the stderr, it is not passed to the client. Not that I expected that flag to do a miracle but, I guess, it proves that the aa output goes to stderr (haven't checked the internals).

This issue is also present in radare2.

caribpa commented 3 years ago

After #552 resolution, I came to say that this issue is also present when using =!= <fd> instead of == <fd>.

What's weird is that this issue doesn't happen when directly connecting to the server:

# Server
$ rz rap://:8080

# Client
$ rz rap://localhost:8080/rizin
> aa
# [x] Analyze all flags starting with sym. and entry0 (aa) ✅ 

This issue is also present in radare2.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. Considering a lot has probably changed since its creation, we kindly ask you to check again if the issue you reported is still relevant in the current version of rizin. If it is, update this issue with a comment, otherwise it will be automatically closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. Considering a lot has probably changed since its creation, we kindly ask you to check again if the issue you reported is still relevant in the current version of rizin. If it is, update this issue with a comment, otherwise it will be automatically closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. Considering a lot has probably changed since its creation, we kindly ask you to check again if the issue you reported is still relevant in the current version of rizin. If it is, update this issue with a comment, otherwise it will be automatically closed if no further activity occurs. Thank you for your contributions.