search

rizinorg / rz-pipe

Access rizin via pipe from any programming language!
33 stars 11 forks source link

Rust rz-pipe shouldn't panic #11

Closed spacemeowx2 closed 11 months ago

spacemeowx2 commented 3 years ago

As a library, rz-pipe should not panic user's process.

All uses of unwrap and expect should be removed. Use error instead.

https://github.com/rizinorg/rz-pipe/blob/76e7b67456aa73770478c0161a230b2ed6420145/rust/src/rzpipe.rs#L216

https://github.com/rizinorg/rz-pipe/blob/76e7b67456aa73770478c0161a230b2ed6420145/rust/src/rzpipe.rs#L265-L272

https://github.com/rizinorg/rz-pipe/blob/76e7b67456aa73770478c0161a230b2ed6420145/rust/src/rzpipe.rs#L332-L337

https://github.com/rizinorg/rz-pipe/blob/76e7b67456aa73770478c0161a230b2ed6420145/rust/src/rzpipe.rs#L354

https://github.com/rizinorg/rz-pipe/blob/76e7b67456aa73770478c0161a230b2ed6420145/rust/src/rz.rs#L21

4thel00z commented 3 years ago

Pls review @XVilka / @spacemeowx2 and pardon my rust n00bness lel

XVilka commented 1 year ago

@spacemeowx2 does this still happen?