search

rizinorg / rz-pipe

Access rizin via pipe from any programming language!
33 stars 11 forks source link

Feature/rust remove unwrap #13

Closed 4thel00z closed 3 years ago

4thel00z commented 3 years ago

Addressed issues pointed out in https://github.com/rizinorg/rz-pipe/issues/11.

My rust is rusty though - no pun intended lel.

spacemeowx2 commented 3 years ago

I would recommend thiserror for defining Error type.

And I think it is ok to break API and bump version to 0.2.0.

4thel00z commented 3 years ago

Thanks @spacemeowx2, @XVilka. Sure will give it a go in a few (approx in 10-15h).

4thel00z commented 3 years ago

I gave it another shot @spacemeowx2 / @XVilka. If it is not "rustonic" enough please point out what I can improve, I haven't touched rust in ages..

officialcjunior commented 3 years ago

Thank you @4thel00z ! Awesome job.