search

rizinorg / rz-pipe

Access rizin via pipe from any programming language!
33 stars 11 forks source link

Feature/issue 8 add pytest #15

Closed 4thel00z closed 3 years ago

4thel00z commented 3 years ago

This is a draft pull request to add some testing for the python bindings #8.

It adds some general improvements like providing context manager helpers and also gets rid of usage of eval. Please add some suggestions and whatever is needed to it @XVilka

XVilka commented 3 years ago

Could you please also add a pytest step to the CI? https://github.com/rizinorg/rz-pipe/blob/master/.github/workflows/ci.yml

4thel00z commented 3 years ago

Could you please also add a pytest step to the CI? https://github.com/rizinorg/rz-pipe/blob/master/.github/workflows/ci.yml

Sure

XVilka commented 3 years ago

@4thel00z do you still consider this PR as a draft? Is it ready for the review?

4thel00z commented 3 years ago

@4thel00z do you still consider this PR as a draft? Is it ready for the review?

yes, I had an accident and am not so much on my machine atm. will take couple days pls check im.rizin.re, sent you a pm

@XVilka

XVilka commented 3 years ago

@4thel00z is this PR ready for the review? It looks finished to me. I would just add pylint check to the CI steps and merge it right away.

4thel00z commented 3 years ago

Hi @XVilka pls feel free to, I hadn't much time to revise. Will open up a new PR for more imrpovs

XVilka commented 3 years ago

@wargio @officialcjunior please take a look again.

XVilka commented 3 years ago

I have very limited python knowledge, by the way.

I have never seen people with unlimited knowledge.

4thel00z commented 3 years ago

have very limited python knowledge, by the way.

It means you have more new stuff you can learn, which is nice :-)

officialcjunior commented 3 years ago

Yes! :)