search

rizinorg / rz-tracetest

Testing of RzIL against real traces
8 stars 5 forks source link

PPC trace adapter #6

Closed Rot127 closed 2 years ago

Rot127 commented 2 years ago

This PR adds the PPC Trace adapter. With it it brings several other needed additions.

Rot127 commented 2 years ago

I see also formatting changes here. Did you run clang-format? In that case, I recommend adding also a configuration here plus a simple CI action to check the formatting for any new PRs.

Formatting was added here: https://github.com/rizinorg/rz-tracetest/pull/7 Would add the CI script in another PR.

Rot127 commented 2 years ago

@XVilka What are the formatting changes you are talking about?

thestr4ng3r commented 2 years ago

CI script seems a bit excessive to me since the commits happen rather rarely in here.

XVilka commented 2 years ago

@XVilka What are the formatting changes you are talking about?

Sorry, I can't see them now. Maybe it was my imagination or mixed with some other PR.

Rot127 commented 2 years ago

The commit referenced by the bap-frames submodule does not seem to exist in the currently used upstream bap repo. Where is it located at the moment?

My bad. I added the PPC flags but forgot to open a pull request for BAP-frames.

Rot127 commented 2 years ago

PR for bap-frames: https://github.com/BinaryAnalysisPlatform/bap-frames/pull/21