rizmaulana / kotlin-mvvm-covid19

This repository contains simple COVID19 data monitoring with android stack MVVM, Live Data, Koin, RxJava, RxBinding, Offline first with simple caching, etc
Apache License 2.0
435 stars 111 forks source link

Location Detail BottomSheet #18

Open fajarnuha opened 4 years ago

fajarnuha commented 4 years ago

right now when we click a point location in a map, it only shows locationName, it is not so informative

instead, we can show a second bottomsheet showing the detail information about the location, reuse partial_country_info will do, might also add Pin to Dashboard button to make it easier for user to reach

pandubaraja commented 4 years ago

I think we can use BottomSheetDialogFragment class to create this feature

fajarnuha commented 4 years ago

i thought using bottom_sheet_behaviour would be just fine but only COLLAPSE mode, we will coordinate the behaviour with the list bottomsheet

using BottomSheetDialogFragment would block the the interaction with map if i recall

pandubaraja commented 4 years ago

Good point

i thought using bottom_sheet_behaviour would be just fine but only COLLAPSE mode, we will coordinate the behaviour with the list bottomsheet

using BottomSheetDialogFragment would block the the interaction with map if i recall

Good point @fajarnuha the UX would become bad if we use BottomSheetDialogFragment, it will block the interaction as you mentioned.

rizmaulana commented 4 years ago

Good idea mas @fajarnuha @pandubaraja I will create PR for this tonight.

fajarnuha commented 4 years ago

please put your name in Assignees if you already started doing this task @rizmaulana

rizmaulana commented 4 years ago

Done mas @fajarnuha

philodi-dev commented 4 years ago

what a about a different pincountry attached to the dashboard overview according to your localization

fajarnuha commented 4 years ago

what a about a different pincountry attached to the dashboard overview according to your localization

first of all @Phil-Jayz you can create a new issue to request this feature and yes, that would be a great idea, so please create the issue so we can discuss it

fajarnuha commented 4 years ago

and @rizmaulana , no need to hurry but, are you still working on this feature?

rizmaulana commented 4 years ago

Not yet mas @fajarnuha planning this week to working on it.

fajarnuha commented 4 years ago

cool, good luck 😎