search

rizmaulana / kotlin-mvvm-covid19

This repository contains simple COVID19 data monitoring with android stack MVVM, Live Data, Koin, RxJava, RxBinding, Offline first with simple caching, etc
Apache License 2.0
435 stars 111 forks source link

Add daily graph and fix minor issue #28

Closed rizmaulana closed 4 years ago

rizmaulana commented 4 years ago
  1. Add daily graph for deltaConfirmed and deltaRecovere https://github.com/rizmaulana/kotlin-mvvm-covid19/issues/17

image

  1. Resolve https://github.com/rizmaulana/kotlin-mvvm-covid19/issues/25

  2. Add send feedback feature, will share link response soon

Seems .gitignore not working properly, will create separate PR to fix them

pandubaraja commented 4 years ago
  1. Add daily graph for deltaConfirmed and deltaRecovere #17

image

  1. Resolve #25
  2. Add send feedback feature, will share link response soon

Seems .gitignore not working properly, will create separate PR to fix them

Nicely done!! 🎉 🥇

rizmaulana commented 4 years ago
  1. Add daily graph for deltaConfirmed and deltaRecovere #17

image

  1. Resolve #25
  2. Add send feedback feature, will share link response soon

Seems .gitignore not working properly, will create separate PR to fix them

Nicely done!! 🎉 🥇

Thanks mas, need your code review 🙏

pandubaraja commented 4 years ago

Oh I see you do not make it as view holder because it is like visual map fragment Sorry for noticing it just now @rizmaulana recycleview only in bottom sheet behavior

fajarnuha commented 4 years ago

actually, i was kinda imagining the other graph, i was more interested in graph showing total number of cases (not daily update) but i notice that's different api and feature, haha, so other than my missed imagination, this PR is good to go, great work @rizmaulana

just try to consider some suggestion in code review

fajarnuha commented 4 years ago

and also dont forget to mark it as Resolve #17

rizmaulana commented 4 years ago

Oh I see you do not make it as view holder because it is like visual map fragment Sorry for noticing it just now @rizmaulana recycleview only in bottom sheet behavior

Yes, it is. Still don't have idea how to implement view holder with fixed layout 😅

pandubaraja commented 4 years ago

Oh I see you do not make it as view holder because it is like visual map fragment Sorry for noticing it just now @rizmaulana recycleview only in bottom sheet behavior

Yes, it is. Still don't have idea how to implement view holder with fixed layout 😅

Me too 😆 ahahahaha

pandubaraja commented 4 years ago

Cool image app preview!! @rizmaulana 🎉 🎉 Please add the pinned feature too on dashboard preview if you have free time 🙏

rizmaulana commented 4 years ago

Sure mas @pandubaraja will modif image preview soon 🙏