search

rizmaulana / kotlin-mvvm-covid19

This repository contains simple COVID19 data monitoring with android stack MVVM, Live Data, Koin, RxJava, RxBinding, Offline first with simple caching, etc
Apache License 2.0
435 stars 111 forks source link

Add support bahasa #30

Closed suryamudti closed 4 years ago

pandubaraja commented 4 years ago

Hi @suryamudti please merge your branch with updated master. So the .gitignore updated to the latest version and the .idea folder will be ignored.

Thank you! 🙏

Ref: https://stackoverflow.com/questions/32384473/gitignore-not-ignoring-idea-path

suryamudti commented 4 years ago

Done. Thanks for the guidance,

fajarnuha commented 4 years ago

I notice your PR isn't clean, please update your branch with master branch so we can see your changes more clearly

pandubaraja commented 4 years ago

Hi @suryamudti could you create a new branch from master

After that you can use cherry-pick to apply the only needed commits from the previous branch you work on to the new branch?

So we can see your changes more clearly as @fajarnuha said. 👓 👨‍💻

suryamudti commented 4 years ago

Hi @pandubaraja, Sure, will try it. Thanks

rizmaulana commented 4 years ago

Cherry pick commit here https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/31