search

rizmaulana / kotlin-mvvm-covid19

This repository contains simple COVID19 data monitoring with android stack MVVM, Live Data, Koin, RxJava, RxBinding, Offline first with simple caching, etc
Apache License 2.0
435 stars 111 forks source link

Add support for bahasa #31

Closed suryamudti closed 4 years ago

suryamudti commented 4 years ago

Hi @rizmaulana Here for screenshot

Description : only add string support for Bahasa, this for support general public in indonesia

pandubaraja commented 4 years ago

I think the .idea folder is still not ignored because @suryamudti has cached changes .idea on his project, @suryamudti it seem you need to execute the script below on your branch

git rm --cached -r .idea

this will remove the cached .idea on your project

@rizmaulana

Let me know if it still happens @suryamudti, I will try to reproduce it on your fork right now

ref: https://stackoverflow.com/questions/32384473/gitignore-not-ignoring-idea-path

suryamudti commented 4 years ago

Thanks @pandubaraja

Hope the latest commit is green to proceed 👨‍💻👀

pandubaraja commented 4 years ago

Oh I see your forked master branch is still behind @rizmaulana master branch because of that your new branch is still not ignoring .idea @suryamudti

image

pandubaraja commented 4 years ago

Thanks @pandubaraja

Hope the latest commit is green to proceed 👨‍💻👀

I think you missed one Daily Updates

image

pandubaraja commented 4 years ago

Thanks @pandubaraja Hope the latest commit is green to proceed 👨‍💻👀

I think you missed one Daily Updates

image Oh sorry it still hardcoded in our current master, it will use strings.xml in this PR https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/28

suryamudti commented 4 years ago

Thanks @pandubaraja Hope the latest commit is green to proceed 👨‍💻👀

I think you missed one Daily Updates image Oh sorry it still hardcoded in our current master, it will use strings.xml in this PR #28

suryamudti commented 4 years ago

@fajarnuha I found the "Daily Updates" words in in the DashboardViewModel,

rizmaulana commented 4 years ago

@fajarnuha I found the "Daily Updates" words in in the DashboardViewModel,

Oh I see mas @suryamudti , wait this PR to be merged https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/28/, I just remove hardcoded string there

rizmaulana commented 4 years ago

Merged mas @suryamudti , please sync with master

suryamudti commented 4 years ago

Okay mas @rizmaulana

rizmaulana commented 4 years ago

It seems not clear PR mas @suryamudti 🤔 do you rebase your branch with master when sync with the latest?

suryamudti commented 4 years ago

yes, any advice mas @rizmaulana ?

suryamudti commented 4 years ago

move to PR #33 🙏🏻