search

rizmaulana / kotlin-mvvm-covid19

This repository contains simple COVID19 data monitoring with android stack MVVM, Live Data, Koin, RxJava, RxBinding, Offline first with simple caching, etc
Apache License 2.0
435 stars 111 forks source link

add menu localization for change the language #35

Closed Faresapn closed 4 years ago

Faresapn commented 4 years ago

this feature to change languange with menu bar , so we can easily change the language

rizmaulana commented 4 years ago

Is it to change the entire system language setting? I think it would be better if we only change default locale on our app

Faresapn commented 4 years ago

because sometimes the default language is English and he wants to change the language to Indonesian and sometimes confused where to set

Pada tanggal Rab, 18 Mar 2020 pukul 20.17 Rizki Maulana < notifications@github.com> menulis:

Is it to change the entire system language setting? I think it would be better if we only change default locale on our app

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/35#issuecomment-600616974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJOS5WXBGJ2D72WD7TCM4ATRIDCXZANCNFSM4LOFHF4Q .

fajarnuha commented 4 years ago

I think changing system language isn't this app's job, @rizmaulana is right, changing default locale on app looks better

Faresapn commented 4 years ago

okey good luck