Improvement Pinned Item

rizmaulana / kotlin-mvvm-covid19

This repository contains simple COVID19 data monitoring with android stack MVVM, Live Data, Koin, RxJava, RxBinding, Offline first with simple caching, etc

Apache License 2.0

435 stars 111 forks source link

Improvement Pinned Item #40

Closed pandubaraja closed 4 years ago

pandubaraja commented 4 years ago

This PR includes:

Unpin
Label Pin on Location Item
VisitableRecyclerAdapter long click functionality
Fix when bottom sheet expanded and keyboard shows up user cannot scroll to the last item because window adjust is not resizing the bottom sheet, therefore the content is behind the keyboard.
Generating CompositeKey(countryRegion + provinceState)to pin and unpin instead the CovidDetail obj.

Preview: ezgif com-resize

pandubaraja commented 4 years ago

Sorry took a long time, got some works to do 🙏

pandubaraja commented 4 years ago

Please review it again @fajarnuha Thank you! 🙏

fajarnuha commented 4 years ago

LGTM 🎉

rizmaulana commented 4 years ago

Good work mas @pandubaraja 🎉