search

rizmaulana / kotlin-mvvm-covid19

This repository contains simple COVID19 data monitoring with android stack MVVM, Live Data, Koin, RxJava, RxBinding, Offline first with simple caching, etc
Apache License 2.0
435 stars 111 forks source link

Implement Indonesia API #43

Closed rizmaulana closed 4 years ago

rizmaulana commented 4 years ago

This issue https://github.com/rizmaulana/kotlin-mvvm-covid19/issues/38 There are some minor issue change and add new feature

PS : Sorry for much changes on one PR, I think next week will be busy week and I don't know if I have enough time to do all this task, so finish it today 😹 I have some tech debt that I will resolve to next PR :

  1. Unit test for new view model
  2. Caching item for Indonesian API
  3. Proper loading and error state for indonesia API
  4. Maybe you found some hard coded string that I missed
  5. Sorry for spagety code, will fix later 😹
Task Screenshot
Change shimmer layout image
Add Entry Point Detail Country - Indonesia image
Add Entry Point Detail Country - Indonesia Content Cell
Add Per Province Graph image
Add daily graph and list per country image
Add Homescreen widget image
rizmaulana commented 4 years ago

Btw guys @fajarnuha @pandubaraja I will create release from this branch as 0.4.0, will patch soon if we found bug.

pandubaraja commented 4 years ago

@rizmaulana do not forget to tag it 🙏 so we can do the hotfix from there and merge it into the master

Anyway that a lot of features you're shipping! Superb 👍 👍 Love that widget 🎉 🎉! Review is on the way!

rizmaulana commented 4 years ago

Thanks mas @pandubaraja I will post release on twitter and blast push notif to user, I think sunday evening is really good time to promote product / app 😹 won't miss it.

fajarnuha commented 4 years ago

will you merge this @rizmaulana but there are some conflicts need to be resolved

rizmaulana commented 4 years ago

will you merge this @rizmaulana but there are some conflicts need to be resolved

On it mas @fajarnuha

rizmaulana commented 4 years ago

Please review this changes mas @fajarnuha @pandubaraja

philodi-dev commented 4 years ago

but, it would be good to show a default pin of a specific region to dashboard on oncreate

Le sam. 28 mars 2020 à 10:46, Rizki Maulana notifications@github.com a écrit :

Please review this changes mas @fajarnuha https://github.com/fajarnuha @pandubaraja https://github.com/pandubaraja

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/43#issuecomment-605464824, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH5ECEDFENJCAXBTQMHVQ7LRJYLT5ANCNFSM4LRJLXPA .

philodi-dev commented 4 years ago

I have implemented a more advanced of that feature already in my local version. I'm only bitting on how to add a default pin of a specific region in dashboard

Le sam. 28 mars 2020 à 11:17, Pandu Baraja notifications@github.com a écrit :

@pandubaraja commented on this pull request.

A little more!

In app/build.gradle https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/43#discussion_r399679094 :

@@ -143,4 +143,6 @@ dependencies {

 // spek requires kotlin-reflect, omit when already in classpath

 testImplementation "org.jetbrains.kotlin:kotlin-reflect:1.3.61"

+

  • implementation 'com.jakewharton.threetenabp:threetenabp:1.2.3'

Nice!

In app/src/main/res/values-in/strings.xml https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/43#discussion_r399679565 :

  • Grafik kasus per hari
  • Kasus harian
  • Kasus konfirmasi, pulih dan kematian adalah nilai akumulatif
  • Kasus Baru
  • Kasus Baru : %1$s
  • Update aplikasi
  • (Hari ke-%1$s)
  • Indonesia
  • Hapus pin
  • Lokasi yang di-pin belum di set
  • Buka map, tekan dan tahan pada negara yang dipilih
  • Sumber data : https://covid19.mathdro.id/
  • Memperbaharui data widget …
  • Pembaharuan data widget berhasil
  • Permbaharuan data widget gagal

Typo ⬇️ Suggested change

  • Permbaharuan data widget gagal
  • Pembaharuan data widget gagal

In app/src/main/res/values/strings.xml https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/43#discussion_r399679785 :

 <string name="unpin">Unpin</string>
  • Pinned location is not set
  • Open map, tap and hold to country item, remove and add this widget once more
  • Data source : https://covid19.mathdro.id/
  • Updating widget data …
  • Updating widget data success

⬇️ Suggested change

  • Updating widget data success
  • Updating widget data successful

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/43#pullrequestreview-383325834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH5ECEBPF3ET6CFK243DCZTRJYPJ7ANCNFSM4LRJLXPA .

rizmaulana commented 4 years ago

Thanks, resolved mas @pandubaraja

pandubaraja commented 4 years ago

Hi @Phil-Jayz, please create a PR so we can check it Thank you 🙏

philodi-dev commented 4 years ago

ok

Le sam. 28 mars 2020 à 11:25, Pandu Baraja notifications@github.com a écrit :

Hi @Phil-Jayz https://github.com/Phil-Jayz, please create a PR so we can check it Thank you 🙏

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rizmaulana/kotlin-mvvm-covid19/pull/43#issuecomment-605477716, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH5ECEFOZ6IBDSUCMQOMPVLRJYQJBANCNFSM4LRJLXPA .