Dynamically show total and delta graph while supporting landscape mode

rizmaulana / kotlin-mvvm-covid19

This repository contains simple COVID19 data monitoring with android stack MVVM, Live Data, Koin, RxJava, RxBinding, Offline first with simple caching, etc

Apache License 2.0

435 stars 111 forks source link

Dynamically show total and delta graph while supporting landscape mode #44

Closed fajarnuha closed 4 years ago

fajarnuha commented 4 years ago

pr2

Hi all these are changes been made in this PR (sorry if its too big for a PR):

Fix error caused by the new changing response API
Show total number line chart alongside with existing delta chart
Support basic dynamic view both for portrait and landscape mode, Resolves #42
Slightly improve visitor pattern adapter to look only single point of truth LAYOUT instead of two

kindly review @rizmaulana @pandubaraja

rizmaulana commented 4 years ago

Nice feature mas @fajarnuha 🎉 is all thread resolved? this PR is good to merge.

i think so, ill merge tomorrow if there is no more feedback