search

rizmaulana / kotlin-mvvm-covid19

This repository contains simple COVID19 data monitoring with android stack MVVM, Live Data, Koin, RxJava, RxBinding, Offline first with simple caching, etc
Apache License 2.0
435 stars 111 forks source link

Fix reported cases count in pie chart #53

Closed fgaim closed 4 years ago

fgaim commented 4 years ago

confirmed=active+recovered+deaths

The confirmed cases include the number of deaths and recovered cases. Therefore:

  1. We should plot the count of active infections instead of confirmed cases.
  2. The total reported cases (inside the pie chart) is just the same as the confirmed cases, instead of confirmed+recovered+deaths.
fajarnuha commented 4 years ago

this looks good to me, can any one of you @rizmaulana @pandubaraja review this too?

pandubaraja commented 4 years ago

Can I merge this @rizmaulana ?

rizmaulana commented 4 years ago

Sure mas @pandubaraja sorry for slow response 🙏