search

rizmut / libreoffice-style-colibre

Colibre Icon Theme for LibreOffice
17 stars 1 forks source link

Feature request - Zotero plugin Icons #9

Open hydroEng opened 3 years ago

hydroEng commented 3 years ago

Hi,

Thanks for this wonderful and modern icon theme for LO. Just wanted to request whether you would be willing to make a new icon set for the Zotero LibreOffice plugin. Many people rely on this across all operating systems, so it would be great if the icons fit in with the rest of the set. See current icons below:

image

Here is the github repo

https://github.com/zotero/zotero-libreoffice-integration

Thanks :)

rizmut commented 3 years ago

Thanks for opening the issue. It's up to Zotero developer to create a variant of Colibre style or completely switch to it. I can help draw the icon but of course the final decision is not on me. :)

rizmut commented 3 years ago

I have found this similar request as well: https://github.com/zotero/zotero-libreoffice-integration/issues/43

hydroEng commented 3 years ago

Ah okay, hopefully the devs will respond positively to your comment!

hydroEng commented 2 years ago

Hello, was wondering if anyone picked this up? From what I understand from your link this probably won't be happening, I assume?

raffaem commented 2 years ago

I have found this similar request as well: zotero/zotero-libreoffice-integration#43

I have replied to you :)

If you can work on it, I will try to add it to the LibreOffice extension.

I have previously PR the Zotero LibreOffice extension :)

rizmut commented 2 years ago

HI I am working on this request. I hope also there will be dark variant support too since I will create two variants.

raffaem commented 2 years ago

Hi, this is now available on my fork

rizmut commented 2 years ago

Hi, this is now available on my fork

Nice, seems I can close this feature request from now.

rizmut commented 2 years ago

Hi, this is now available on my fork

Nice, thank you very much for your work

This is how it looked image image image image

hydroEng commented 2 years ago

Would it be possible to provide a new icon set that works well in both light and dark mode, that can replace the current default one?

To be honest the main issue with the default theme is that it looks bad in dark mode (also looks kind of outdated).

Maybe if there is any interest from @rizmut for creating a singular set of icons, would the plugin maintainer be in principle interested in that?

rizmut commented 2 years ago

Would it be possible to provide a new icon set that works well in both light and dark mode, that can replace the current default one?

Unfortunately the answer is no, Colibre is not intended to be adaptive like that. So far it's Yaru's icon theme that has a similar vision, and I don't like that approach because it makes the icon thickness less consistent between the light and dark variants.

hydroEng commented 2 years ago

Would it be possible to provide a new icon set that works well in both light and dark mode, that can replace the current default one?

Unfortunately the answer is no, Colibre is not intended to be adaptive like that. So far it's Yaru's icon theme that has a similar vision, and I don't like that approach because it makes the icon thickness less consistent between the light and dark variants.

Sorry to be annoying but, as it stands, your new theme works much better in dark mode than the zotero default.

image

I understand this might not follow standard adaptive design practices but all you would need to do would be to change the color of the last icon (the chain link) to something that works well in both dark and light mode.

If I ask the plugin maintainer whether they would be interested in upstreaming your light variant of the colibre icon theme if you make this change, would you be willing to update it?

rizmut commented 1 year ago

If I ask the plugin maintainer whether they would be interested in upstreaming your light variant of the colibre icon theme if you make this change, would you be willing to update it?

I have no intention to do so, anyone can do the task anyway if interested. Sorry for very late response.