rizonesoft / Notepad3

Notepad like text editor based on the Scintilla source code. Notepad3 based on code from Notepad2 and MiniPath on code from metapath. Download Notepad3:
https://www.rizonesoft.com/downloads/notepad3/
Other
5.06k stars 334 forks source link

Gap between line number and text #347

Closed sanGtH closed 6 years ago

sanGtH commented 6 years ago

Hello, Can we remove the gap that appears between the line number and beginning of text ? I have attached the screenshot. notepad3_prob

phonphen commented 6 years ago

just goto and uncheck View -> Code Folding or Ctrl+Shift+Alt+F

RaiKoHoff commented 6 years ago

@phonphen is right, this gap is related to "Code Folding" feature. You will get another gap (in margin area) if you activate the View -> Selection Margin feature (Ctrl+Shift+M). If activated, the Bookmarks appearance switched from highlighted line to a marker within this margin (color styling available).

Regarding the Code Folding feature: I think, there maybe lexers, which do not have a "Code Folding" detector implemented, at least the "Default Text" lexer. It could be an enhancement to disable the Code Folding for these lexers ?

sanGtH commented 6 years ago

Thanks everyone :) just out of curiousity, is Notepad3 an extension of Notepad2 ? Because I see Flo balmer in the contributors' list and that Notepad2 has not been in the development scene for quite some time ? Am i saying right ?

RaiKoHoff commented 6 years ago

Notepad3 is forked from Notepad2-mod, which is based on Flo's incredible Notepad2 (v.4) source code. Meanwhile a lot of enhancements and features have been added to Notepad3.

craigo- commented 6 years ago

Regarding the Code Folding feature: I think, there maybe lexers, which do not have a "Code Folding" detector implemented, at least the "Default Text" lexer. It could be an enhancement to disable the Code Folding for these lexers ?

I've been thinking about this.

I'd be hesitant about allowing Notepad3 to change a user setting based on the detected lexer (i.e. it toggling the Code Folding feature itself)...

If there were some way for Notepad3 to internally disable the code folding feature if the detected lexer did not support it, that would be better... But I'd like it to be clear in the UI what was going on. It would be confusing and inconsistent if the code folding margin disappeared, but the feature still appeared in the menu as if it were turned on. A possible solution in this scenario might be for the menu entry to maintain its setting but be greyed out..?

RaiKoHoff commented 6 years ago

Please try beta version 3.18.213.884. Lexers, which don't support folding: STD, 2nd STD, ANSI, MAKE, BATCH, MARKDOWN, Apache Configuration Files. New Look: Folding Column is "integrated" in Margins (Scintilla: Folding belongs to Margins). Configuration (Colors, Size) is bundled with Bookmarks, to get a consistent look and feel.

RaiKoHoff commented 6 years ago

Related Notepad2-mod issue (https://github.com/XhmikosR/notepad2-mod/issues/161)

RaiKoHoff commented 6 years ago

In beta version 3.18.214.886, I enabled some more styling for Folding Markers: charset:0/1 - boxes (0) = std or circles (1) (see 2nd Default Text) case:L/U - single line (L) = std or double line (U) (see 2nd Default Text)

craigo- commented 6 years ago

Beta build 3.8.214.886: The code folding elements have moved seamlessly into the line number margin, and Notepad3 gracefully disables code folding for those schemes that do not cater for it. Nice to have the alternative indicator options too... although I'll be sticking to the square variety.

@RaiKoHoff, I am not seeing any visual difference between case:L and case:U for the "Bookmarks and Folding (colors) style..? And the default setting is the same (case:U) for both the "Default Text" and "2nd Default Text" schemes..?

RaiKoHoff commented 6 years ago

The difference betweencase:L and case:U is (in case of folded block) a "single line after heading" vs. "double line enclosing heading". You are right with default settings - this will be corrected in next beta.

craigo- commented 6 years ago

Ah, I see. Thanks.

RaiKoHoff commented 6 years ago

I think, I will switch the options:

craigo- commented 6 years ago

Sounds good to me.

hpwamr commented 6 years ago

@RaiKoHoff , @craigo- Hello guys, this is a very good and very nice improvements for NP3. I like it ! 👍 ❤️

craigo- commented 6 years ago

Beta build 3.18.215.887:

Default Text / Bookmarks and Folding (Colors)

This style has the following configured in a fresh install:

fore:#000000; back:#00FF00; alpha:80; case:L

...but the Reset button resets it to this:

fore:#000000; back:#00FF00; alpha:80

i.e. it removes the trailing "case:L" statement. It has no effect, as it seems that is the default behaviour, but... the Reset button should return the setting to its as-shipped state. Suggestion: update the behaviour of the Reset button.

2nd Default Text / Bookmarks and Folding (Colors)

This style has the following configured in a fresh install:

fore:#000000; back:#00FF00; alpha:80; charset:1; case:U;

...but the Reset button resets it to this:

fore:#000000; back:#00FF00; alpha:80; charset:2; case:U;

i.e. it changes the "charset" element to 2. This should probably be standardised to one or the other.

Additionally, both the as-shipped and the reset value have that annoying trailing semicolon that to the best of my knowledge occurs nowhere else... :smile:

RaiKoHoff commented 6 years ago

The shipped .ini-Files do not have any customized schemes for the lexers, so the initial settings rely on internal defaults, which is also the reset setting. Maybe you didn't start with the shipped .ini file?

craigo- commented 6 years ago

Weird... I always test with a freshly unpacked portable version, but I must have done something different in this case. Sorry, you are quite right; ignore most of what I said.

...except for the semicolon!

RaiKoHoff commented 6 years ago

..except for the semicolon: Please test beta version 3.18.216.890.

craigo- commented 6 years ago

Tested beta build 3.18.216.892: all good. Thanks.

RaiKoHoff commented 6 years ago

@sanGtH : Please test release version 3.18.223.908 and close this issue if solved.

sanGtH commented 6 years ago

Closing