[Feature Request] Increasing the MAX-Length of [Customize Schemes] --> (FileName Extensions) text/string box.

MelchiorGaspar commented 7 years ago

Title says it pretty well...

Can use ALSO increase the size File TYPE extension lists in "Customize Scheme" window..??+

back from NP2, this had a hard coded limit in NP2.... I asked Flo some where in the past few years but he didn't want to.. :( X( I asked because had added so many extensions to the ini config section that I ran into that hard wall...

could you double, triple, quadruple that limit? that is if you haven't already done so...

I tried looking through the code to find where this value is stored.. but... I am not sure what I'm looking for so...

MelchiorGaspar commented 7 years ago

@rizonesoft could u add a Enhancement label to my ticket... please... I can't seem to find the option to do it myself.. probably because its not my repo.. lol ;)

rizonesoft commented 7 years ago

Will do.

On 3 Oct 2017 17:18, "Joseph DeVore" notifications@github.com wrote:

@rizonesoft https://github.com/rizonesoft could u add a Enhancement label to my ticket... please... I can't seem to find the option to do it myself.. probably because its not my repo.. lol ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rizonesoft/Notepad3/issues/51#issuecomment-333875898, or mute the thread https://github.com/notifications/unsubscribe-auth/AIPY2AG-zTPF2oID5T9RioawCStdK7tJks5solAwgaJpZM4O1j_S .

rizonesoft commented 7 years ago

Added an Enancement label.

RaiKoHoff commented 7 years ago

@MelchiorGaspar I tried to implement this FeatureRequest and build a development test version of NP3: (Download: https://drive.google.com/drive/folders/0B7X3F11Wq7qSczNXU0V0NmQ2aWc?usp=sharing) I like to ask you to download and test this Version (focus: Customize Schemes...) Please test all aspects of customizing scheme(s), save, reload, cancel, etc. "Style settings" should still have a text box buffer size of 256 chars. "Associated filename extensions" box should have a size of 1024 chars. Please report any issue/crash you may encounter ... ;-)

MelchiorGaspar commented 7 years ago

256 and 1024 sounds great... what were the original values for NP3 and NP2? pretty sure I could not add anymore to the [ini/inf] and/or [XML] extension boxes in NP2...

here is my usage of the extension list of the ones I modified the most...

C/C++ source code (54 characters long) c; cpp; cxx; cc; h; hpp; hxx; hh; m; mm; idl; inl; odl

web source code (87 characters long) html; htm; asp; aspx; shtml; htd; xhtml; php; php3; phtml; htt; cfm; tpl; dtd; hta; htc

makefiles (62 characters long) mak; make; mk; dc; dsp; msvc; ms; in; am; mingw32; gcc; la; ac

ini/inf files (121 characters long) ini; inf; cfg; properties; oem; sif; url; sed; theme; ins; scf; dat; psr; rdx; rdn; rdb; cht; lily; ucon64rc; development

resource files (29 characters long) rc; rc2; rct; rh; r; dlg; ver

XML Documents (109 characters long) xml; xsml; xsl; rss; svg; xul; xsd; xslt; axl; xaml; rdf; vcproj; kml; cbp; manifest; wsdl; xrc; xspf; layout

so ini/inf and XML are the two types I have added too the most.. various text/src/config file types that uses those formats.. a lot for Emulator settings/Config files..

I can test it I guess.. ooh joy more testing.. meow... ;-) :P

RaiKoHoff commented 7 years ago

@MelchiorGaspar : the old (NP2-mod) sizes for these buffers were 128 chars for both. Sometimes the Dialogbox has been allowed to put in more characters, but finally they were cut off to fit 128. As far as i can see, for "Style Settings" the old size of 256 is good enough - there are not more key-words to fill that space. For "Associated filename extensions", i will make a cut at 512, that should be enough. There is no answer from you about testing, i assume everything is OK, so i will go to propose a Pull Request (PR) for Notepad3 next release.

MelchiorGaspar commented 7 years ago

lol I didn't quite get around ti testing i the sense you linked me a PortableApp style build for that site instead of the regular archive non installed version.. so I was unsure out to proceed..

ie creating a test directory next to my main NP3 folder.. copying settings over to the test folder.. lol ;) yeah... plus not sure what to test for exactly or go about it.. I don't recall the newer extensions I wanted to add.. lol ;) :P only that I could not add them to NP2 for ini/inf and xml because I had run out of space/buffer for it.. lol ;)

PS: did u guys fix that bug were the extra style settings were not being kept/saved like bold? font:Courier New; smoothing:cleartype; size:10; fore:#0080FF; back:#C0C0C0; bold

I don't recall of hand ;-) lol

256 for Styles sound like plenty and 512 for extensions us ooh YEAH! lol ;-)

RaiKoHoff commented 7 years ago

... regarding your PS: yes, extra style font settings "bold" and "italic" should have been fixed.

rizonesoft / Notepad3

[Feature Request] Increasing the MAX-Length of [Customize Schemes] --> (FileName Extensions) text/string box. #51

here is my usage of the extension list of the ones I modified the most...

so ini/inf and XML are the two types I have added too the most.. various text/src/config file types that uses those formats.. a lot for Emulator settings/Config files..