rizonesoft / Notepad3

Notepad like text editor based on the Scintilla source code. Notepad3 based on code from Notepad2 and MiniPath on code from metapath. Download Notepad3:
https://www.rizonesoft.com/downloads/notepad3/
Other
5.05k stars 335 forks source link

NotePad 3 v4.18 and RC v5.18 both Incorrectly selecting line number of first row only! #844

Closed Priyanka-Chopra closed 5 years ago

Priyanka-Chopra commented 5 years ago

Reporting bug - for Notepad3 v4.18.512.992_Setup.zip and Notepad3 v5.18.1106.1434_Setup.exe. Installed on Windows 10 v1809 64-bit with the following issue:

Hereโ€™s a screenshot of what I mean: https://s15.directupload.net/images/181202/z8fvrycn.jpg

screenshot

Description:

With word wrap on, a text line wraps on a second line and so forth, etcetera... when the line or sentence (text) is longer than the display window size. Okay.

So the ISSUE is, when you click on that line number, so as to select the full line of characters that has been word wrapped below, you only get the first row selected, NOT the full highlighted yellow colored text to copy, as expected and wanted).

When clicking on the line number, it is supposed to select the whole line, even if it drops down below as a word wrap.

But in these versions (listed above), unless there is a setting to change this behavior, when selecting the line number, only the first row gets selected for copying despite the whole line number gets colored yellow...

This action should be changed to: when selecting the line number, the full line gets highlighted for copying, even if it is word wrapped.... (right)?

hpwamr commented 5 years ago

Hello @Priyanka-Chopra , I think, it "works as design" in a wrapped line context:

With 1 Click: np3_1click

With 2 Clicks: np3_2clicks

Also If you want, you can try with the latest "Notepad3Portable RC2" version available here, Notepad3Portable_5.18.1201.170_MUI_dev_RC2.paf.7z.

Your suggestions and comments are welcome... ๐Ÿค”

RaiKoHoff commented 5 years ago

@Priyanka-Chopra is right, clicking on the line number should select the complete line - ignoring the long-line-wrapping, considering only line-breaks. Ed.: I have to correct myself: Above behavior, I have been used to from ancient times of Scintilla, meanwhile (2011) there has been a change by Scintilla - for discussion see here. Fixed by Scintilla here. After reading this discussions, I vote for @hpwamr, to stay with current behavior:

Further suggestions and comments are welcome ... ๐Ÿ˜ƒ

Priyanka-Chopra commented 5 years ago

Hi, @hpwamr Pairi Daiza :heart_eyes:

Thank you very much for responding back and explaining the appropriate action of this "selecting function" in your software application. I had not realized the need for a double click action, because before in earlier builds this was done with a single click action. But, having this new function support more ways to select, is therefore more of a benefit to the end user.

Also, thank you for offering the latest RC2 portable version of NotePad 3. However, the tool is so useful in day to day usage, that it gets installed for everyone else rather than as a mobile tool.


Just a Suggest: Can NotePad 3 be designed to follow the operating system theme color scheme for application modes? So that it supports the black (dark) background with white text characters? Many of our employees have expressed a preference for viewing a dark background environment. For the purpose of reducing eye strain when staring at the screen for a long time.

Notepad++ material_theme_npp_screenshot

Firefox (browser):
firefox-dark-mode

Windows Explorer: savtnl1

Visual Studio: 3716 01_rtm

YouTube: youtube-dark-mode

NotePad 3 (Just an Example - Dark Mode Icons Required) snag-00001

hpwamr commented 5 years ago

Just a Suggest: Can NotePad 3 be designed to follow the operating system theme color scheme for application modes? So that it supports the black (dark) background with white text characters? Many of our employees have expressed a preference for viewing a dark background environment. For the purpose of reducing eye strain when staring at the screen for a long time.

Hello @RaiKoHoff I reopened this issue to have a discussion about the suggestion of "Priyanka Chopra". ๐Ÿค”

RaiKoHoff commented 5 years ago

Hello @hpwamr, the Customize Scheme... dialog offers an export/import of all scheme settings. Feel free to create a "dark theme" for all lexers schemes and export them to a DarkThemeScheme.ini. Together with an "optimized dark theme" set of icons, this package could be offered for download ... ๐Ÿค”

hpwamr commented 5 years ago

Hello @RaiKoHoff, Well I don't use "dark theme", but I can put this request on the wishes list of Santa Claus. ๐Ÿ˜ƒ

hpwamr commented 5 years ago

Hello @Priyanka-Chopra , I think you have asked for dark mode in Notepad3... ? :thinking: Could you please review and comment this issue... #1030 Thanks in advance. :smiley:

hpwamr commented 4 years ago

Hello @Priyanka-Chopra , I think you have also asked for dark mode in Notepad3... ? ๐Ÿค” Could you please help us and comment this issue... https://github.com/rizonesoft/Notepad3/issues/2262 Thanks in advance. ๐Ÿ˜ƒ