search

rizowski / eslint-watch

ESLint with simple watching capabilities
https://www.npmjs.com/package/eslint-watch
MIT License
194 stars 29 forks source link

Check if key is defined #116

Closed alasdairtran closed 7 years ago

alasdairtran commented 7 years ago

What was the problem/Ticket Number

When the tool is running and you press a non-character key (e.g. 1, 2, 3, comma, period), the tool crashes since key is undefined.

How does this solve the problem?

Add a check to make sure that key is defined.

How to duplicate the issue

  1. Run the tool in watch mode
  2. Press any non-character key like 1.
rizowski commented 7 years ago

@alasdairtran Thanks for the PR! Once I get my updates in, I'll need you to update your branch and then we can get this in.

alasdairtran commented 7 years ago

@rizowski Thanks for merging my PR! Can you also update the package on npm as well when you have time?

rizowski commented 7 years ago

@alasdairtran Yeah, I will push out the version today.

rizowski commented 7 years ago

This has been deployed for v3.1.1