search

rizowski / eslint-watch

ESLint with simple watching capabilities
https://www.npmjs.com/package/eslint-watch
MIT License
196 stars 29 forks source link

Make gray text readable on Solarized Dark theme #118

Closed s0meone closed 7 years ago

s0meone commented 7 years ago

What was the problem/Ticket Number

Gray text is unreadable with Solarized Dark theme

How does this solve the problem?

Makes the text readable again

How to duplicate the issue

  1. Install Solarized Dark theme
  2. Run esw with simple-detail formatter
  3. Create an lint error
  4. Try to read the output in the terminal

See: https://github.com/eslint/eslint/pull/4885 https://github.com/altercation/solarized/issues/220 https://github.com/chalk/chalk/issues/40

Before image

After image

rizowski commented 7 years ago

@s0meone Thanks for the PR! Once I get my PR in, I'll need you to update your branch and then we can see about getting this in.

s0meone commented 7 years ago

Thanks! 👍🏻