default LIBDIR for Debian

rizsotto / Bear

Bear is a tool that generates a compilation database for clang tooling.

GNU General Public License v3.0

4.79k stars 314 forks source link

default LIBDIR for Debian #410

Closed wortiz closed 3 years ago

wortiz commented 3 years ago

Thanks for the answer in #409 I had missed the updated Install instructions

For Debian systems would you be opposed to something like this as it seems unlikely to get fixed upstream anytime soon? https://gitlab.kitware.com/cmake/cmake/-/issues/20565

I would assume most people are not going to be installing into /usr so for Debian based systems most people won't get the right LIBDIR without reading your Install.md

rizsotto commented 3 years ago

Sorry @wortiz , I am hesitant to fix a CMake bug in this project, because there are too many... the CMAKE_INSTALL_LIBDIR is broken for Fedora and Arch too. Handling this differences should be in CMake.

Debian packages are available for the latest version, which will probably reduce the number of cases when people will build it from sources.
The INSTALL.md is expected to be read when users install it from source. (If the instructions in that file are not clear enough or poorly written, which can be the case since I am not a native English speaker, then let's improve that.)

wortiz commented 3 years ago

@rizsotto I think the INSTALL.md is pretty clear. Unfortunate but understandable that you don't want to put this into the project.

If you have submitted a bug report to CMake if you could link it so I could track that it would be great. I only saw the one I linked above.

I saw some wording in INSTALL.md that looked odd to me, find a patch here if it is useful to you:

installmd_wording.patch.txt

Shall support -> Should/Must support

rizsotto commented 3 years ago

Thanks @wortiz for the patch, will apply it.

No, I have not submitted a ticket about the CMAKE_INSTALL_LIBDIR thing. I'm afraid that the upstream project will reject such request, and redirect to the package making folks. (Fair point, I would say.) And the package making folks would ask to talk to the upstream project... I've seen such loops. :)