search

rizsotto / scan-build

Clang's scan-build re-implementation in python
Other
362 stars 34 forks source link

Only require 'typing' for Python before 3.5 #115

Closed jameysharp closed 5 years ago

jameysharp commented 5 years ago

Fixes #104

jameysharp commented 5 years ago

Huh, okay, the setup.py change doesn't work on Python 3.4.4 on Windows, but does work on Python 3.4.8 on Ubuntu. Maybe support for the ; python_version syntax was added between those two versions? If that's the issue, I think it'd reasonable to say that people who are still on 3.4 need to upgrade to a later patch release. I don't know if you can upgrade the Python version that AppVeyor uses, which I guess would be the easiest way to test this hypothesis.

The TravisCI failure on 3.7 looks like a spurious failure due to a keyserver timeout. You might try restarting that build job.

rizsotto commented 5 years ago

Thanks @jameysharp , it looks good. Will merge it when my vacation is over.

rizsotto commented 5 years ago

thank you!!!