rj200 / Glamarye_Fast_Effects_for_ReShade

Designed for speed, this shader for ReShade is for people who can't just run everything at max settings but want good enough post-processing without costing much framerate. It combines 4 effects in one - Fast FXAA, sharpening, depth of field and fast ambient occlusion
MIT License
115 stars 12 forks source link

Suggestion for reducing AO bleeding through fog/mist etc #5

Closed vrnord closed 2 years ago

vrnord commented 2 years ago

The sliders for AO distance and brightness aren't really helping reduce AO from bleeding through fog, smoke and mist in my modded Skyrim, and Reveil.fx has a relatively high performance cost and doesn't entirely fix it either. However, I notice that most fog/mist/smoke ends up looking grey in-game, and if translucent it has the effect of making whatever is behind it look quite desaturated as well.

So if one could tell your AO to disregard screen areas below "x" saturation threshold via a saturation slider that might greatly improve the bleed-through situation.

rj200 commented 2 years ago

Maybe it could help specific games/locations, but I don't think it can work well in most scenes. I did briefly experiment with that idea the early days of glamayre. 2 problems:

Option: use the game's built-in AO instead and turning off glamayre's option. The checkbox for "Cinematic DOF safe mode" might help too - it disables local AO but still allows some of the large-scale AO from the Fake GI effect, but smoothed.

I've thought about doing some global measurement of the contrast/depth ratio but will be imperfect, complicated and probably slow.

The real fix is to apply the shader earlier in the games pipeline before fog is added. This should be possible using the new plugin mechanism in ReShade 6.0. However, no-one has written a plugin to do it yet.

vrnord commented 2 years ago

I appreciate the reply!